All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <dada1@cosmosbay.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PACH] smp: uninline num_online_cpus() & num_possible_cpus()
Date: Tue, 09 Dec 2008 07:36:00 +0100	[thread overview]
Message-ID: <493E11D0.6020702@cosmosbay.com> (raw)
In-Reply-To: <200812091433.03670.rusty@rustcorp.com.au>

Rusty Russell a écrit :
> On Saturday 06 December 2008 04:03:44 Eric Dumazet wrote:
>> num_online_cpus() and num_possible_cpus() are not performance
>> critical and are quite large.
>>
>> Unlining them shrinks kernel text size by 7523 bytes on x86,
>> if NR_CPUS>32
> 
> Hi Eric!
> 
>   Slight misdiagnosis, I think.  One base problem is addressed in fixing
> the bitmap operators (see "[PATCH] bitmap: test for constant as well as
> small size for inline versions" on lkml Message-Id: <200811160907.07140.rusty@rustcorp.com.au>).  This is already in
> linux-next, and I've pasted it below.
> 
>   Worse, you used the obsolete cpumask operators :)
> 

I see ! Good work ;)

So the gain would be 11 bytes per call site, and about one hundred calls,
maybe not worth it :)

Thanks



      reply	other threads:[~2008-12-09  6:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-05 17:33 [PACH] smp: uninline num_online_cpus() & num_possible_cpus() Eric Dumazet
2008-12-08 22:43 ` Andrew Morton
2008-12-09  4:03 ` Rusty Russell
2008-12-09  6:36   ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=493E11D0.6020702@cosmosbay.com \
    --to=dada1@cosmosbay.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.