From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <jbeulich@novell.com>
Subject: Re: [PATCH] fix ia64 breakage with PHYSDEVOP_pirq_eoi_mfn (was
	Re: [PATCH 2/2] linux/x86: use shared page
	indicating the need for an EOI notification)
Date: Tue, 09 Dec 2008 10:54:57 +0000
Message-ID: <493E5C91.76E4.0078.0@novell.com>
References: <493D30D6.76E4.0078.0@novell.com>
	<20081209034038.GO5454%yamahata@valinux.co.jp>
	<493E50D7.76E4.0078.0@novell.com>
	<20081209104310.GR5454%yamahata@valinux.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20081209104310.GR5454%yamahata@valinux.co.jp>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: xen-devel@lists.xensource.com, Keir Fraser <keir.fraser@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

>>> Isaku Yamahata <yamahata@valinux.co.jp> 09.12.08 11:43 >>>
>You are the first person to pass the kernel symbol address
>to virt_to_machine() in arch independent code.
>Is there any necessity to allocate pirq_needs_eoi statically?
>(except it did before)

Perhaps not - avoiding the possible allocation failure (-> BUG()) and the
extra indirection were the main reasons I kept it allocated statically.

>If no, can we allocate the pages for them dynamically?
>Then the issue will go away.

Indeed.

>Introduce ptep_to_machine() or something like that?

Yes, if that name isn't ambiguous in some way.

Jan