From: Timur Tabi <timur@freescale.com>
To: Guillaume Knispel <gknispel@proformatique.com>
Cc: linuxppc-dev@ozlabs.org,
Pantelis Antoniou <pantelis@embeddedalley.com>,
Li Yang <leoli@freescale.com>,
Joakim Tjernlund <joakim.tjernlund@transmode.se>
Subject: Re: [PATCH] Fix corruption error in rh_alloc_fixed()
Date: Tue, 09 Dec 2008 09:16:50 -0600 [thread overview]
Message-ID: <493E8BE2.809@freescale.com> (raw)
In-Reply-To: <20081209161422.5e289e6c@xilun.lan.proformatique.com>
Guillaume Knispel wrote:
> blk = NULL; at the end of the loop is what is done in the more used
> rh_alloc_align(), so for consistency either we change both or we use
> the same construction here.
> I also think that testing for &info->free_list is harder to understand
> because you must have the linked list implementation in your head
> (which a kernel developer should anyway so this is not so important)
Fair enough.
Acked-by: Timur Tabi <timur@freescale.com>
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2008-12-09 15:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 14:28 [PATCH] Fix corruption error in rh_alloc_fixed() Guillaume Knispel
2008-12-09 15:03 ` Timur Tabi
2008-12-09 15:14 ` Guillaume Knispel
2008-12-09 15:16 ` Timur Tabi [this message]
2008-12-14 18:50 ` Guillaume Knispel
2008-12-14 21:21 ` Paul Mackerras
2008-12-15 0:32 ` Guillaume Knispel
2008-12-16 18:23 ` Kumar Gala
2008-12-17 1:13 ` Paul Mackerras
2008-12-17 16:00 ` Kumar Gala
2008-12-17 16:11 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493E8BE2.809@freescale.com \
--to=timur@freescale.com \
--cc=gknispel@proformatique.com \
--cc=joakim.tjernlund@transmode.se \
--cc=leoli@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=pantelis@embeddedalley.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.