All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Christian Lamparter <chunkeey@web.de>
Cc: linux-wireless@vger.kernel.org,
	John W Linville <linville@tuxdriver.com>,
	Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH v2] p54usb: rewriting rx/tx routines to make use of usb_anchor's facilities
Date: Tue, 09 Dec 2008 09:45:57 -0600	[thread overview]
Message-ID: <493E92B5.90803@lwfinger.net> (raw)
In-Reply-To: <200812091514.37634.chunkeey@web.de>

Christian Lamparter wrote:
> Alan Stern found several flaws in p54usb's implementation and annotated: 
> "usb_kill_urb() and similar routines do not expect an URB's completion
> routine to deallocate it.  This is almost obvious -- if the URB is deallocated
> before the completion routine returns then there's no way for usb_kill_urb
> to detect when the URB actually is complete."
> 
> This patch addresses all known limitations in the old implementation and fixes
> khub's "use-after-freed" hang, when SLUB debug's poisoning option is enabled.
> 
> Signed-off-by: Christian Lamparter <chunkeey@web.de>
> Cc: stable@kernel.org
> ---

Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
---



  parent reply	other threads:[~2008-12-09 15:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-09 14:14 [PATCH v2] p54usb: rewriting rx/tx routines to make use of usb_anchor's facilities Christian Lamparter
2008-12-09 14:35 ` John W. Linville
2008-12-09 14:46   ` Johannes Berg
2008-12-09 14:54     ` John W. Linville
2008-12-09 15:03       ` Johannes Berg
2008-12-09 15:16         ` Larry Finger
2008-12-09 15:07   ` Larry Finger
2008-12-09 15:45 ` Larry Finger [this message]
2008-12-09 16:11   ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=493E92B5.90803@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=chunkeey@web.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.