From: Roel Kluin <roel.kluin@gmail.com>
To: v4l-dvb-maintainer@linuxtv.org, lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH 16/33] DVB: Make static
Date: Tue, 09 Dec 2008 19:56:08 +0100 [thread overview]
Message-ID: <493EBF48.7020701@gmail.com> (raw)
In-Reply-To: <493EA286.7080500@gmail.com>
Sparse asked whether these could be static.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
drivers/media/dvb/dm1105/dm1105.c | 4 ++--
drivers/media/dvb/dvb-core/dvb_frontend.c | 25 ++++++++++++++-----------
drivers/media/dvb/dvb-usb/anysee.c | 2 +-
drivers/media/dvb/dvb-usb/cinergyT2-core.c | 4 ++--
drivers/media/dvb/frontends/cx24116.c | 2 +-
5 files changed, 20 insertions(+), 17 deletions(-)
diff --git a/drivers/media/dvb/dm1105/dm1105.c b/drivers/media/dvb/dm1105/dm1105.c
index c1d92f8..a0bc379 100644
--- a/drivers/media/dvb/dm1105/dm1105.c
+++ b/drivers/media/dvb/dm1105/dm1105.c
@@ -507,7 +507,7 @@ static void input_register_keys(struct infrared *ir)
ir->input_dev->keycodemax = ARRAY_SIZE(ir->key_map);
}
-int __devinit dm1105_ir_init(struct dm1105dvb *dm1105)
+static int __devinit dm1105_ir_init(struct dm1105dvb *dm1105)
{
struct input_dev *input_dev;
int err;
@@ -551,7 +551,7 @@ int __devinit dm1105_ir_init(struct dm1105dvb *dm1105)
}
-void __devexit dm1105_ir_exit(struct dm1105dvb *dm1105)
+static void __devexit dm1105_ir_exit(struct dm1105dvb *dm1105)
{
tasklet_kill(&dm1105->ir.ir_tasklet);
input_unregister_device(dm1105->ir.input_dev);
diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c
index 7a421e9..a432c1a 100644
--- a/drivers/media/dvb/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb/dvb-core/dvb_frontend.c
@@ -764,7 +764,7 @@ static int dvb_frontend_check_parameters(struct dvb_frontend *fe,
return 0;
}
-struct dtv_cmds_h dtv_cmds[] = {
+static struct dtv_cmds_h dtv_cmds[] = {
[DTV_TUNE] = {
.name = "DTV_TUNE",
.cmd = DTV_TUNE,
@@ -902,7 +902,7 @@ struct dtv_cmds_h dtv_cmds[] = {
},
};
-void dtv_property_dump(struct dtv_property *tvp)
+static void dtv_property_dump(struct dtv_property *tvp)
{
int i;
@@ -933,7 +933,7 @@ void dtv_property_dump(struct dtv_property *tvp)
dprintk("%s() tvp.u.data = 0x%08x\n", __func__, tvp->u.data);
}
-int is_legacy_delivery_system(fe_delivery_system_t s)
+static int is_legacy_delivery_system(fe_delivery_system_t s)
{
if((s == SYS_UNDEFINED) || (s == SYS_DVBC_ANNEX_AC) ||
(s == SYS_DVBC_ANNEX_B) || (s == SYS_DVBT) || (s == SYS_DVBS) ||
@@ -947,7 +947,8 @@ int is_legacy_delivery_system(fe_delivery_system_t s)
* drivers can use a single set_frontend tuning function, regardless of whether
* it's being used for the legacy or new API, reducing code and complexity.
*/
-void dtv_property_cache_sync(struct dvb_frontend *fe, struct dvb_frontend_parameters *p)
+static void dtv_property_cache_sync(struct dvb_frontend *fe,
+ struct dvb_frontend_parameters *p)
{
struct dtv_frontend_properties *c = &fe->dtv_property_cache;
@@ -999,7 +1000,7 @@ void dtv_property_cache_sync(struct dvb_frontend *fe, struct dvb_frontend_parame
/* Ensure the cached values are set correctly in the frontend
* legacy tuning structures, for the advanced tuning API.
*/
-void dtv_property_legacy_params_sync(struct dvb_frontend *fe)
+static void dtv_property_legacy_params_sync(struct dvb_frontend *fe)
{
struct dtv_frontend_properties *c = &fe->dtv_property_cache;
struct dvb_frontend_private *fepriv = fe->frontend_priv;
@@ -1054,7 +1055,7 @@ void dtv_property_legacy_params_sync(struct dvb_frontend *fe)
/* Ensure the cached values are set correctly in the frontend
* legacy tuning structures, for the legacy tuning API.
*/
-void dtv_property_adv_params_sync(struct dvb_frontend *fe)
+static void dtv_property_adv_params_sync(struct dvb_frontend *fe)
{
struct dtv_frontend_properties *c = &fe->dtv_property_cache;
struct dvb_frontend_private *fepriv = fe->frontend_priv;
@@ -1089,7 +1090,7 @@ void dtv_property_adv_params_sync(struct dvb_frontend *fe)
}
}
-void dtv_property_cache_submit(struct dvb_frontend *fe)
+static void dtv_property_cache_submit(struct dvb_frontend *fe)
{
struct dtv_frontend_properties *c = &fe->dtv_property_cache;
@@ -1120,8 +1121,9 @@ static int dvb_frontend_ioctl_legacy(struct inode *inode, struct file *file,
static int dvb_frontend_ioctl_properties(struct inode *inode, struct file *file,
unsigned int cmd, void *parg);
-int dtv_property_process_get(struct dvb_frontend *fe, struct dtv_property *tvp,
- struct inode *inode, struct file *file)
+static int dtv_property_process_get(struct dvb_frontend *fe,
+ struct dtv_property *tvp, struct inode *inode,
+ struct file *file)
{
int r = 0;
@@ -1193,8 +1195,9 @@ int dtv_property_process_get(struct dvb_frontend *fe, struct dtv_property *tvp,
return r;
}
-int dtv_property_process_set(struct dvb_frontend *fe, struct dtv_property *tvp,
- struct inode *inode, struct file *file)
+static int dtv_property_process_set(struct dvb_frontend *fe,
+ struct dtv_property *tvp, struct inode *inode,
+ struct file *file)
{
int r = 0;
struct dvb_frontend_private *fepriv = fe->frontend_priv;
diff --git a/drivers/media/dvb/dvb-usb/anysee.c b/drivers/media/dvb/dvb-usb/anysee.c
index cd2edbc..c9eda4e 100644
--- a/drivers/media/dvb/dvb-usb/anysee.c
+++ b/drivers/media/dvb/dvb-usb/anysee.c
@@ -41,7 +41,7 @@
static int dvb_usb_anysee_debug;
module_param_named(debug, dvb_usb_anysee_debug, int, 0644);
MODULE_PARM_DESC(debug, "set debugging level" DVB_USB_DEBUG_STATUS);
-int dvb_usb_anysee_delsys;
+static int dvb_usb_anysee_delsys;
module_param_named(delsys, dvb_usb_anysee_delsys, int, 0644);
MODULE_PARM_DESC(delsys, "select delivery mode (0=DVB-C, 1=DVB-T)");
DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr);
diff --git a/drivers/media/dvb/dvb-usb/cinergyT2-core.c b/drivers/media/dvb/dvb-usb/cinergyT2-core.c
index 3ac9f74..ef23719 100644
--- a/drivers/media/dvb/dvb-usb/cinergyT2-core.c
+++ b/drivers/media/dvb/dvb-usb/cinergyT2-core.c
@@ -32,7 +32,7 @@
/* debug */
int dvb_usb_cinergyt2_debug;
-int disable_remote;
+static int disable_remote;
module_param_named(debug, dvb_usb_cinergyt2_debug, int, 0644);
MODULE_PARM_DESC(debug, "set debugging level (1=info, xfer=2, rc=4 "
@@ -45,7 +45,7 @@ struct cinergyt2_state {
};
/* We are missing a release hook with usb_device data */
-struct dvb_usb_device *cinergyt2_usb_device;
+static struct dvb_usb_device *cinergyt2_usb_device;
static struct dvb_usb_device_properties cinergyt2_properties;
diff --git a/drivers/media/dvb/frontends/cx24116.c b/drivers/media/dvb/frontends/cx24116.c
index b144b30..74f9750 100644
--- a/drivers/media/dvb/frontends/cx24116.c
+++ b/drivers/media/dvb/frontends/cx24116.c
@@ -368,7 +368,7 @@ static int cx24116_set_inversion(struct cx24116_state *state,
* Not all S2 mmodulation schemes are support and not all rates with
* a scheme are support. Especially, no auto detect when in S2 mode.
*/
-struct cx24116_modfec {
+static struct cx24116_modfec {
fe_delivery_system_t delivery_system;
fe_modulation_t modulation;
fe_code_rate_t fec;
next prev parent reply other threads:[~2008-12-09 18:56 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 16:53 [PATCH 0/33] Make static Roel Kluin
2008-12-09 16:55 ` [PATCH 1/33] Documentation: " Roel Kluin
2008-12-22 19:38 ` Randy Dunlap
2008-12-09 16:58 ` [PATCH 2/33] x86: " Roel Kluin
2008-12-09 19:50 ` Frederik Deweerdt
2008-12-09 19:57 ` [PATCH 2/33 V2] " Roel Kluin
2008-12-09 17:00 ` [PATCH 3/33] block: " Roel Kluin
2008-12-10 14:46 ` Jens Axboe
2008-12-09 17:02 ` [PATCH 4/33] drivers/acpi: " Roel Kluin
2008-12-09 19:45 ` [PATCH 4/33 v2] " Roel Kluin
2008-12-09 17:05 ` [PATCH 5/33] drivers/block/floppy: " Roel Kluin
2008-12-09 17:12 ` [PATCH 6/33] drivers/char: " Roel Kluin
2008-12-09 17:52 ` [PATCH 7/33] drivers/dca: " Roel Kluin
2008-12-09 17:54 ` [PATCH 8/33] drivers/edac: " Roel Kluin
2008-12-09 18:26 ` [PATCH 10/33] drm/i915: " Roel Kluin
[not found] ` <493EA286.7080500-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-12-09 18:41 ` [PATCH 12/33] i2c: " Roel Kluin
2008-12-09 18:41 ` Roel Kluin
2008-12-09 19:04 ` Jean Delvare
[not found] ` <20081209200409.17fac29f-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-12-09 22:53 ` roel kluin
2008-12-09 22:53 ` roel kluin
2008-12-09 18:44 ` [PATCH 13/33] Input: " Roel Kluin
2008-12-09 18:50 ` [PATCH 14/33] isdn: " Roel Kluin
2008-12-11 9:48 ` Armin Schindler
2008-12-09 18:52 ` [PATCH 15/33] leds: " Roel Kluin
2008-12-09 18:56 ` Roel Kluin [this message]
2008-12-09 18:59 ` [PATCH 17/33] drivers/misc: " Roel Kluin
2008-12-09 19:06 ` [PATCH 18/33] drivers/net: " Roel Kluin
2008-12-10 0:42 ` Jeff Kirsher
2008-12-09 20:49 ` [PATCH 18/31] drivers/pci: " Roel Kluin
2008-12-09 22:53 ` Jesse Barnes
2008-12-09 21:12 ` [PATCH 19/31] drivers/pcmcia: " Roel Kluin
2008-12-09 21:20 ` [PATCH 20/31] drivers/pnp: " Roel Kluin
2008-12-09 21:41 ` [PATCH 21/31] drivers/power: " Roel Kluin
2008-12-09 21:50 ` [PATCH 23/31] drivers/usb: " Roel Kluin
2008-12-09 21:56 ` [PATCH 24/31] drivers/video: " Roel Kluin
2008-12-09 22:06 ` [PATCH 25/31] fs: " Roel Kluin
2008-12-09 22:11 ` [PATCH 26/31] kernel: " Roel Kluin
2008-12-09 22:14 ` [PATCH 27/31] mm: " Roel Kluin
2008-12-09 22:14 ` Roel Kluin
2008-12-09 22:20 ` [PATCH 28/31] net: " Roel Kluin
2008-12-10 23:18 ` David Miller
2008-12-09 22:22 ` [PATCH 29/31] markers: " Roel Kluin
2008-12-09 22:53 ` Mathieu Desnoyers
2009-02-19 4:29 ` Mathieu Desnoyers
2008-12-09 22:26 ` [PATCH 30/31] sound: " Roel Kluin
2008-12-10 14:21 ` Takashi Iwai
2008-12-09 22:28 ` [PATCH 31/31] virt: " Roel Kluin
2008-12-10 10:07 ` Avi Kivity
2008-12-10 10:23 ` Avi Kivity
2008-12-09 22:52 ` [PATCH 22/31] scsi: " Roel Kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493EBF48.7020701@gmail.com \
--to=roel.kluin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.