From: Heiko Schocher <heiko.schocher@invitel.hu>
To: u-boot@lists.denx.de
Subject: [U-Boot] show_boot_progess @ ppc not working
Date: Wed, 10 Dec 2008 08:27:01 +0100 [thread overview]
Message-ID: <493F6F45.5060205@invitel.hu> (raw)
In-Reply-To: <493E4FD6.4000803@matrix-vision.de>
Hello Andre,
Andre Schwarz wrote:
> All,
>
> can someone tell me why the board specific function "void
> show_boot_progress(int arg)"
> is no longer called (at least on MPC5200).
>
> Of course this line is present in the board config :
>
> #define CONFIG_SHOW_BOOT_PROGRESS 1
>
>
> What have I missed ?
>
Nothing! Good catch. I tried it on a mpc8xx and
on a mpx82xx based board and it also didnt worked :-(
Can you try the following patch? (This patch solved it
on my boards ...)
thanks,
Heiko
[PATCH] all platforms: make show_boot_progress () again working.
Signed-off-by: Heiko Schocher <hs@denx.de>
---
include/common.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/common.h b/include/common.h
index 5968036..6583f00 100644
--- a/include/common.h
+++ b/include/common.h
@@ -693,7 +693,7 @@ int pcmcia_init (void);
/*
* Board-specific Platform code can reimplement show_boot_progress ()
if needed
*/
-void __attribute__((weak)) show_boot_progress (int val);
+void show_boot_progress (int val);
#ifdef CONFIG_INIT_CRITICAL
#error CONFIG_INIT_CRITICAL is deprecated!
--
1.5.6.1
next prev parent reply other threads:[~2008-12-10 7:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 11:00 [U-Boot] show_boot_progess @ ppc not working Andre Schwarz
2008-12-09 11:21 ` Heiko Schocher
2008-12-09 11:24 ` Andre Schwarz
2008-12-10 7:27 ` Heiko Schocher [this message]
2008-12-10 9:56 ` Andre Schwarz
2008-12-10 10:58 ` Graeme Russ
2008-12-10 11:04 ` Andre Schwarz
2009-06-22 9:57 ` André Schwarz
2009-06-28 9:09 ` Heiko Schocher
2009-06-29 8:16 ` André Schwarz
2009-06-29 10:16 ` Heiko Schocher
2009-07-04 22:29 ` Wolfgang Denk
2009-07-05 7:05 ` Heiko Schocher
2009-07-08 19:39 ` Wolfgang Denk
2009-07-09 5:27 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493F6F45.5060205@invitel.hu \
--to=heiko.schocher@invitel.hu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.