From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jes Sorensen <jes@sgi.com>
Date: Wed, 10 Dec 2008 08:28:19 +0000
Subject: Re: [patch] fix kvm_arch_vcpu_ioctl_[gs]et_regs()
Message-Id: <493F7DA3.4060507@sgi.com>
List-Id: <kvm-ia64.vger.kernel.org>
References: <493E906C.8030800@sgi.com>
In-Reply-To: <493E906C.8030800@sgi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kvm-ia64@vger.kernel.org

Zhang, Xiantao wrote:
> Jes
>    Good work!  I ever talked about the issue with Avi and wanted to enable the logic with the following patch, and Avi thought it may lead to security issues, so deferred to now :) 
> 
> One comment:  We still need the logic to save and restore the vcpu's stack for vcpu resuming to the guest in the same environment.  Maybe you can allocate one buf to save it in kvm_reg structure.
> Xiantao

Hi Xiantao,

I am with Avi on this one - we shouldn't be passing in pointers like
that. Either we can increase the size of kvm_regs as you mention, but it
will become *huge* since the stack is 64KB, or we introduce a new ioctl
just to handle the stack.

Do you think it would be a problem having the second ioctl for this? I
would prefer breaking it into two to avoid the kernel having to allocate
a 128KB chunk for kvm_regs.

Cheers,
Jes