All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <jes@sgi.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [patch] fix kvm_arch_vcpu_ioctl_[gs]et_regs()
Date: Wed, 10 Dec 2008 08:39:01 +0000	[thread overview]
Message-ID: <493F8025.9060705@sgi.com> (raw)
In-Reply-To: <493E906C.8030800@sgi.com>

Zhang, Xiantao wrote:
> Jes Sorensen wrote:
>> I am with Avi on this one - we shouldn't be passing in pointers like
>> that. Either we can increase the size of kvm_regs as you mention, but
>> it will become *huge* since the stack is 64KB, or we introduce a new
>> ioctl just to handle the stack.
>>
>> Do you think it would be a problem having the second ioctl for this? I
>> would prefer breaking it into two to avoid the kernel having to
>> allocate a 128KB chunk for kvm_regs.
> 
> Fine to me to add the ioctl, and it should make the logic clear. 
> Xiantao

Cool, I'll look into that later today, I hope. I'll base it on your old
code, but I will not be able to test it :-)

Cheers,
Jes

  parent reply	other threads:[~2008-12-10  8:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-09 15:36 [patch] fix kvm_arch_vcpu_ioctl_[gs]et_regs() Jes Sorensen
2008-12-10  2:39 ` Zhang, Xiantao
2008-12-10  8:28 ` Jes Sorensen
2008-12-10  8:36 ` Zhang, Xiantao
2008-12-10  8:39 ` Jes Sorensen [this message]
2008-12-10  8:44 ` Zhang, Xiantao
2008-12-10  9:00 ` Avi Kivity
2008-12-10  9:20 ` Zhang, Xiantao
2008-12-10  9:55 ` Jes Sorensen
2008-12-12 14:44 ` Jes Sorensen
2008-12-13 15:54 ` Zhang, Xiantao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=493F8025.9060705@sgi.com \
    --to=jes@sgi.com \
    --cc=kvm-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.