Re: [Qemu-devel] [PATCH] evdev_keycode_map

[Anthony Liguori <anthony@codemonkey.ws>]

Daniel P. Berrange wrote:
> On Wed, Dec 10, 2008 at 12:42:35AM +0200, Riku Voipio wrote:
>   
>> On Wed, Sep 24, 2008 at 06:10:27PM -0500, Dustin Kirkland wrote:
>>     
>>> I'm attaching a patch that we have applied to the qemu implementation
>>> inside of the kvm package in Ubuntu.
>>>       
>> Anyone know why this patch is still lingering?
>>
>>     
>>> --- kvm-72+dfsg/qemu/configure	2008-07-27 08:20:10.000000000 -0500
>>> +++ kvm-72+dfsg/qemu/configure	2008-09-24 16:04:28.036791147 -0500
>>> @@ -1198,9 +1198,9 @@ if test "$sdl1" = "yes" ; then
>>>    echo "#define CONFIG_SDL 1" >> $config_h
>>>    echo "CONFIG_SDL=yes" >> $config_mak
>>>    if test "$target_softmmu" = "no" -o "$static" = "yes"; then
>>> -    echo "SDL_LIBS=$sdl_static_libs" >> $config_mak
>>> +    echo "SDL_LIBS=-lX11 $sdl_static_libs" >> $config_mak
>>>    else
>>> -    echo "SDL_LIBS=`$sdl_config --libs`" >> $config_mak
>>> +    echo "SDL_LIBS=-lX11 `$sdl_config --libs`" >> $config_mak
>>>    fi
>>>       
>> These changes make the SDL code dependant on X ? This
>> would make compiling windows less trivial..
>>     
>
> It ought to be possible to just #ifdef out the bit of the code which 
> checks for evdev on non-Linux, and just default to the existing 
> mapping QEMU had.
>   

This is what's required for merging.  SDL X11 support needs to be probed 
at configure time, an appropriate #define needs to be added to config.h, 
and then the detection code needs to be enabled conditionally based on 
that #define.

Otherwise, non-X11 SDL platforms will stop building which certainly 
isn't acceptable.

Regards,

Anthony Liguori