All of lore.kernel.org
 help / color / mirror / Atom feed
From: Reinhard Nissl <rnissl@gmx.de>
To: linux-scsi@vger.kernel.org
Subject: PATCH: mvsas: increase port type detection delay to suit Seagate's 10k6 drive ST3450856SS 0003
Date: Thu, 11 Dec 2008 00:31:03 +0100	[thread overview]
Message-ID: <49405137.9000902@gmx.de> (raw)
In-Reply-To: <493BC76F.3060105@gmx.de>

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

I increased the delay step by step until loading of mvsas
reliably detected the drive 200 times in sequence. A much better
approach would be to monitor the hardware for some flag which
indicates that port detection has finished, but I do not have any
hardware documentation.

BTW: patch is against
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.27.y.git

Signed-off-by: Reinhard Nissl <rnissl@gmx.de>


[-- Attachment #2: mvsas.diff --]
[-- Type: text/x-patch, Size: 450 bytes --]

diff --git a/drivers/scsi/mvsas.c b/drivers/scsi/mvsas.c
index 1dd70d7..23e5a87 100644
--- a/drivers/scsi/mvsas.c
+++ b/drivers/scsi/mvsas.c
@@ -2959,7 +2959,7 @@ static int __devinit mvs_hw_init(struct mvs_info *mvi)
 
 	/* enable auto port detection */
 	mw32(GBL_PORT_TYPE, MODE_AUTO_DET_EN);
-	msleep(100);
+	msleep(1100);
 	/* init and reset phys */
 	for (i = 0; i < mvi->chip->n_phy; i++) {
 		u32 lo = be32_to_cpu(*(u32 *)&mvi->sas_addr[4]);

  reply	other threads:[~2008-12-10 23:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-07 12:54 [Fwd: mvsas determines most often an incorrect phy addr of 0 while attaching phy to port (Was: ERROR: Unidentified device type 0)] Reinhard Nissl
2008-12-10 23:31 ` Reinhard Nissl [this message]
2008-12-12 20:23   ` PATCH: mvsas: increase port type detection delay to suit Seagate's 15k6 drive ST3450856SS 0003 Reinhard Nissl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49405137.9000902@gmx.de \
    --to=rnissl@gmx.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.