From: Thomas Monjalon <thomas@monjalon.net>
To: "Ji, Kai" <kai.ji@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "gakhil@marvell.com" <gakhil@marvell.com>
Subject: Re: [dpdk-dev v1] crypto/openssl: EVP_PKEY routine update in rsa op
Date: Tue, 05 Jul 2022 12:55:11 +0200 [thread overview]
Message-ID: <4940951.tlMGI8NQbM@thomas> (raw)
In-Reply-To: <SN6PR11MB3408945D88D6CC9679B8DDB581819@SN6PR11MB3408.namprd11.prod.outlook.com>
05/07/2022 12:43, Ji, Kai:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 30/06/2022 12:38, Kai Ji:
> > > EVP_PKEY function need to be called twice for rsa sign and verify
> > > operations. This patch also remove the OPENSSL_API_COMPAT as all the
> > > deprecated APIs are avoid if 3.0 lib is present.
> >
> > I prefer not pulling this patch for now because it is not clear.
> >
> > 1/ What is fixed exactly? All RSA sign and verify were broken?
> No, this patch fix the 3.0 EVP API in RSA sign and verify routine, original openssl 1.x rsa sign and verify routines are untouched.
> The original patch set for Openssl 3.0 EVP API is here:
> http://patchwork.dpdk.org/project/dpdk/patch/20220621154214.78176-3-kai.ji@intel.com/
>
>
> > 2/ Do you mean OpenSSL 3 is required?
> No, this branch code will be only executed when Openssl 3.0 lib is detected on the host.
OK, please could you reword the commit message
so I can apply it to the commit?
Thanks
next prev parent reply other threads:[~2022-07-05 10:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 10:38 [dpdk-dev v1] crypto/openssl: EVP_PKEY routine update in rsa op Kai Ji
2022-07-01 19:14 ` [EXT] " Akhil Goyal
2022-07-04 19:45 ` Thomas Monjalon
2022-07-05 10:43 ` Ji, Kai
2022-07-05 10:55 ` Thomas Monjalon [this message]
2022-07-05 13:16 ` [dpdk-dev v2] " Kai Ji
2022-07-05 16:33 ` [EXT] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4940951.tlMGI8NQbM@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=kai.ji@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.