Re: [Qemu-devel] [PATCH 3 of 7] [UPDATE] DisplayState interface change

[Stefano Stabellini <stefano.stabellini@eu.citrix.com>]

Anthony Liguori wrote:

> Stefano Stabellini wrote:
>> in particular the following functions are very helpful to manage a
>> DisplaySurface:
>>
>> qemu_createDisplaySurface
>> qemu_resizeDisplaySurface
>> qemu_createDisplaySurfaceFrom
>> qemu_freeDisplaySurface
>>   
> 
> These names suck.  Please change them to something more in line with the
> rest of the code.


Are the capital letters that sucks, or the names?

qemu_create_displaysurface
qemu_resize_displaysurface
qemu_create_displaysurface_from
qemu_free_displaysurface

Are these any better?

>> diff -r f1fd23dcd333 hw/cirrus_vga.c
>> --- a/hw/cirrus_vga.c    Tue Nov 25 12:28:31 2008 +0000
>> +++ b/hw/cirrus_vga.c    Wed Nov 26 11:43:17 2008 +0000
>> @@ -789,22 +789,16 @@
>>      if (BLTUNSAFE(s))
>>          return 0;
>>  
>> -    if (s->ds->dpy_copy) {
>> -    cirrus_do_copy(s, s->cirrus_blt_dstaddr - s->start_addr,
>> -               s->cirrus_blt_srcaddr - s->start_addr,
>> -               s->cirrus_blt_width, s->cirrus_blt_height);
>> -    } else {
>> -    (*s->cirrus_rop) (s, s->vram_ptr +
>> -                (s->cirrus_blt_dstaddr & s->cirrus_addr_mask),
>> -              s->vram_ptr +
>> -                (s->cirrus_blt_srcaddr & s->cirrus_addr_mask),
>> -              s->cirrus_blt_dstpitch, s->cirrus_blt_srcpitch,
>> -              s->cirrus_blt_width, s->cirrus_blt_height);
>> +    (*s->cirrus_rop) (s, s->vram_ptr +
>> +            (s->cirrus_blt_dstaddr & s->cirrus_addr_mask),
>> +            s->vram_ptr +
>> +            (s->cirrus_blt_srcaddr & s->cirrus_addr_mask),
>> +            s->cirrus_blt_dstpitch, s->cirrus_blt_srcpitch,
>> +            s->cirrus_blt_width, s->cirrus_blt_height);
>>   
> 
> You've eliminated the dpy_copy optimization?  This is extremely
> important for VNC.
> 


My approach has been too radical.
I need to remove the memmove from vnc.c, but I should be able to keep
the dpy_copy optimization.