Re: [PATCH] hw/acpi/pcihp: Fix typo in function name

[Eric Auger <eric.auger@redhat.com>]

Hi Gustavo,

On 5/6/25 2:26 AM, Gustavo Romero wrote:
> Hi Eric,
>
> On 5/5/25 11:19, Eric Auger wrote:
>> Hi Gustavo,
>>
>> On 5/5/25 2:29 PM, Gustavo Romero wrote:
>>> Hi Eric,
>>>
>>> On 5/5/25 04:13, Eric Auger wrote:
>>>>
>>>>
>>>> On 5/4/25 11:56 PM, Gustavo Romero wrote:
>>>>> Fix typo in QEMU's ACPI PCI hotplug API function name that checks
>>>>> whether a given bus is hotplug-capable.
>>>>>
>>>>> Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
>>>> Reviewed-by: Eric Auger <eric.auger@redhat.com>
>>>>
>>>> For awareness, there is a similar typo in pci-port.
>>>> see
>>>> https://lore.kernel.org/all/20250428102628.378046-2-eric.auger@redhat.com/
>>>>
>>>>
>>>
>>> hmm it's unfortunate that I was about to publish a series to exactly
>>> enable the APCI PCI hotplug on ARM. Next time I should try to sync
>>> better
>>> with Red Hat folks on the work fronts...
>> Sorry to hear that. That's always a frustrating situation :-(
>
> Yes...
>
>
>>> I've skimmed through your RFC and it seems to be doing mostly of what I
>>> was doing for my series, so I'll reviewed it formally today, it should
>>> be quick.
>> I guess we may need to add some additional qtests for hotplug (just as
>> they have on x86). Maybe we can collaborate on this or you already have
>> some stuff under work.
>
> Sure, the new test I'm baking is the one I've used in the smoke test.
> I'll
> contribute it on top of your series so.
sure
>
> For the x86 "parity", which tests you're thinking of to add for arm64?

I found
https://lore.kernel.org/all/20200918084111.15339-1-ani@anisinha.ca/#r

so in tests/qtest/bios-tables-test.c
tests featuring various values of
acpi-root-pci-hotplug/acpi-pci-hotplug-with-bridge-support

Cheers

Eric
>
>
> Cheers,
> Gustavo
>