From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] pci: virtio: use pci id defines.
Date: Thu, 11 Dec 2008 17:48:43 +0100 [thread overview]
Message-ID: <4941446B.7030606@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 182 bytes --]
Hi,
Use the defines added by the previous patch in the virtio drivers.
Also remove the pointless vendor and device args from the
virtio_blk_init() function.
please apply,
Gerd
[-- Attachment #2: 0022-pci-virtio-use-pci-id-defines.patch --]
[-- Type: text/plain, Size: 3138 bytes --]
>From 47472ad689b422de944b761c9397ada7d80763f2 Mon Sep 17 00:00:00 2001
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 11 Dec 2008 15:29:48 +0100
Subject: [PATCH] pci: virtio: use pci id defines.
Use the defines added by the previous patch in the virtio drivers.
Also remove the pointless vendor and device args from the
virtio_blk_init() function.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/pc.c | 3 +--
hw/virtio-balloon.c | 3 ++-
hw/virtio-blk.c | 7 ++++---
hw/virtio-blk.h | 3 +--
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index 20827f2..73dd8bc 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -1101,8 +1101,7 @@ static void pc_init1(ram_addr_t ram_size, int vga_ram_size,
int unit_id = 0;
while ((index = drive_get_index(IF_VIRTIO, 0, unit_id)) != -1) {
- virtio_blk_init(pci_bus, 0x1AF4, 0x1001,
- drives_table[index].bdrv);
+ virtio_blk_init(pci_bus, drives_table[index].bdrv);
unit_id++;
}
}
diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c
index e668436..0765516 100644
--- a/hw/virtio-balloon.c
+++ b/hw/virtio-balloon.c
@@ -172,7 +172,8 @@ void *virtio_balloon_init(PCIBus *bus)
VirtIOBalloon *s;
s = (VirtIOBalloon *)virtio_init_pci(bus, "virtio-balloon",
- 6900, 0x1002,
+ PCI_VENDOR_ID_REDHAT_QUMRANET,
+ PCI_DEVICE_ID_VIRTIO_BALLOON,
0, VIRTIO_ID_BALLOON,
0x05, 0x00, 0x00,
8, sizeof(VirtIOBalloon));
diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
index 91b90d2..e654cc5 100644
--- a/hw/virtio-blk.c
+++ b/hw/virtio-blk.c
@@ -218,14 +218,15 @@ static int virtio_blk_load(QEMUFile *f, void *opaque, int version_id)
return 0;
}
-void *virtio_blk_init(PCIBus *bus, uint16_t vendor, uint16_t device,
- BlockDriverState *bs)
+void *virtio_blk_init(PCIBus *bus, BlockDriverState *bs)
{
VirtIOBlock *s;
int cylinders, heads, secs;
static int virtio_blk_id;
- s = (VirtIOBlock *)virtio_init_pci(bus, "virtio-blk", vendor, device,
+ s = (VirtIOBlock *)virtio_init_pci(bus, "virtio-blk",
+ PCI_VENDOR_ID_REDHAT_QUMRANET,
+ PCI_DEVICE_ID_VIRTIO_BLOCK,
0, VIRTIO_ID_BLOCK,
0x01, 0x80, 0x00,
sizeof(struct virtio_blk_config), sizeof(VirtIOBlock));
diff --git a/hw/virtio-blk.h b/hw/virtio-blk.h
index c6661c0..8c91e1e 100644
--- a/hw/virtio-blk.h
+++ b/hw/virtio-blk.h
@@ -70,7 +70,6 @@ struct virtio_blk_inhdr
unsigned char status;
};
-void *virtio_blk_init(PCIBus *bus, uint16_t vendor, uint16_t device,
- BlockDriverState *bs);
+void *virtio_blk_init(PCIBus *bus, BlockDriverState *bs);
#endif
--
1.5.6.5
reply other threads:[~2008-12-11 16:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4941446B.7030606@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.