Re: [PATCH] netfilter: ctnetlink: fix missing CTA_NAT_SEQ_UNSPEC

[Pablo Neira Ayuso <pablo@netfilter.org>]

Patrick McHardy wrote:
> Pablo Neira Ayuso wrote:
>> This patch fixes an inconsistency in nfnetlink_conntrack.h that
>> I introduced myself. The problem is that CTA_NAT_SEQ_UNSPEC is
>> missing from enum ctattr_natseq. This inconsistency may lead to
>> problems in the message parsing in userspace (if the message
>> contains the CTA_NAT_SEQ_* attributes, of course).
>>
>> This patch breaks backward compatibility, however, the only known
>> client of this code is libnetfilter_conntrack which indeed crashes
>> because it assumes the existence of CTA_NAT_SEQ_UNSPEC to do
>> the parsing.
>>
>> The CTA_NAT_SEQ_* attributes were introduced in 2.6.25.
> 
> Applied, thanks.

Thanks Patrick. This one should go to 2.6.28 as bugfix I think. Do you
plan to pass it to David?

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers