From: "H. Peter Anvin" <hpa@zytor.com>
To: Greg KH <gregkh@suse.de>
Cc: Zachary Amsden <zach@vmware.com>, Yinghai Lu <yinghai@kernel.org>,
Huang Ying <ying.huang@intel.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
"norman@thebacks.co.uk" <norman@thebacks.co.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alok Kataria <alokkataria1@gmail.com>,
"bruno.premont@restena.lu" <bruno.premont@restena.lu>,
"xl@xlsigned.net" <xl@xlsigned.net>,
"dsd@gentoo.org" <dsd@gentoo.org>
Subject: Re: [PATCH] Fix VMI crash on boot in 2.6.27, 2.6.28 kernels
Date: Thu, 11 Dec 2008 15:37:14 -0800 [thread overview]
Message-ID: <4941A42A.7030607@zytor.com> (raw)
In-Reply-To: <20081211214524.GA31581@suse.de>
Greg KH wrote:
>> +#else
>> +#define vmi_init()
>> +#define vmi_activate()
>> +#define vmi_bringup()
>> +#endif
>
> static inline please, don't use #defines for function prototypes, it's
> not nice. See Andrew's previous rants about this for details :)
And if it is not possible, technically, for whatever reason, the proper
forms look like:
#define foo() ((void)0)
#define bar(x) ((void)(x))
#define baz(x,y) ((void)((x),(y)))
... which preserve side effects, even if they don't guarantee type safety.
-hpa
next prev parent reply other threads:[~2008-12-11 23:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 0:50 [PATCH] Fix VMI crash on boot in 2.6.27+ kernels Zachary Amsden
2008-12-10 0:44 ` Greg KH
2008-12-10 7:30 ` Zachary Amsden
2008-12-10 1:15 ` Yinghai Lu
2008-12-10 1:48 ` H. Peter Anvin
2008-12-10 7:31 ` Zachary Amsden
2008-12-10 9:05 ` H. Peter Anvin
2008-12-10 7:36 ` Zachary Amsden
2008-12-11 0:06 ` Zachary Amsden
2008-12-11 0:20 ` Yinghai Lu
2008-12-11 3:31 ` Greg KH
2008-12-11 22:23 ` [PATCH] Fix VMI crash on boot in 2.6.27, 2.6.28 kernels Zachary Amsden
2008-12-11 21:45 ` Greg KH
2008-12-11 23:37 ` H. Peter Anvin [this message]
2008-12-12 5:37 ` Zachary Amsden
2008-12-11 5:44 ` [PATCH] Fix VMI crash on boot in 2.6.27+ kernels Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4941A42A.7030607@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=alokkataria1@gmail.com \
--cc=bruno.premont@restena.lu \
--cc=dsd@gentoo.org \
--cc=gregkh@suse.de \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=norman@thebacks.co.uk \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=xl@xlsigned.net \
--cc=ying.huang@intel.com \
--cc=yinghai@kernel.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.