Thanks for comments. v2 comes :) Keir Fraser wrote: > On 11/12/2008 07:09, "Zhai, Edwin" wrote: > > >> Monitor Trap Flag (MTF), is a debugging feature that cause vmexit on >> certain instruction boundaries, which can be used for HVM single step. >> We prefer MTF over TF, as it make TF free for guest use. >> >> This patch try to enable MTF for single step in gdb, and keep backward >> compatibility on old processor. >> >> Pls. see MTF details @ SDM 3b 21.7.2 >> > > Don't need EVENTTYPE_OTHER. Don't need to modify svm.c at all. The hvm_param > is gross since there is no obvious symmetric get() to go with your set() -- > please just hack in a domctl, that'd be neater in this case imo even though > specific right now to x86 hvm. > > That'll do for comments on patch v1... :-) > > -- Keir > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > > -- best rgds, edwin