All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC/PATCH] Add preadv and pwritev system calls.
Date: Fri, 12 Dec 2008 10:19:38 +0100	[thread overview]
Message-ID: <49422CAA.4070502@redhat.com> (raw)
In-Reply-To: <20081211234908.GA11305@infradead.org>

Christoph Hellwig wrote:
> 
> Looks good, but you should Cc linux-arch so that arch maintainers get
> a heads up to wire up the syscalls.

Will do for the next version.

>> +	if (ret > 0)
>> +		add_rchar(current, ret);
>> +	inc_syscr(current);
>> +	return ret;
> 
> Could it be that these are missing for the compat case both for the existing
> readv/writev and your new syscalls?

Yep, seems so, I can't spot them anywhere in compat.c.
I'll sort that too.

thanks,
  Gerd

      reply	other threads:[~2008-12-12  9:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-11 23:13 [RFC/PATCH] Add preadv and pwritev system calls Gerd Hoffmann
2008-12-11 23:49 ` Christoph Hellwig
2008-12-12  9:19   ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49422CAA.4070502@redhat.com \
    --to=kraxel@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.