All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] FSL DDR @ 83xx
Date: Fri, 12 Dec 2008 13:13:55 -0600	[thread overview]
Message-ID: <4942B7F3.3000001@freescale.com> (raw)
In-Reply-To: <4940E05B.8000805@matrix-vision.de>

Andre Schwarz wrote:

>> I don't believe anyone is currently working on getting the new ddr
>> code to be used w/83xx.  Feel free to submit patches that does this
>> and we will review them as they are posted.
>>
>> - k
> After spending few hours it seems to work basically.
> This is what I've done :
> 
> - add mpc8xxx(ddr/libddr.a to top level Makefile for 83xx
> - created mpc83xx/ddr-gen2.c and ported to meet ddr83xx_t
> - created board specific ddr.c for SPD accessor and basic setup.
> - created board specific ddr2_spd_eeprom_t (soldered memory)
> 
> The board config got these #defines :
> 
> #define CONFIG_FSL_DDR2
> #define CONFIG_DDR_SPD
> #define CONFIG_NUM_DDR_CONTROLLERS      1           -> this should go
> into mpc83xx header
> #define CONFIG_DIMM_SLOTS_PER_CTLR      1
> #define CONFIG_CHIP_SELECTS_PER_CTRL    1
> 
> Since spd_sdram.o is always build (mpc83xx/Makefile) and the code is
> also activated by CONFIG_SPD_EEPROM
> we should find a reasonable way  to switch between "old" and "new" DDR
> code by some kind of #define.
> 
> Is this the way to go ?
> 

Yes, it is.  You will also need a per-board set of functions
to answer the "configuration issues" in a way similar to the
rest of the 85xx and 86xx boards.

You will have to carefully juggle the presence of the
"new" and "old" simultaneously (via CONFIG_FSL_DDR2, likely)
until all the 83xx boards are supported under the new mechanism.

jdl

  reply	other threads:[~2008-12-12 19:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-08 17:02 [U-Boot] FSL DDR @ 83xx Andre Schwarz
2008-12-08 19:50 ` Jon Loeliger
2008-12-09 18:01   ` Andre Schwarz
2008-12-09 19:04     ` Kumar Gala
2008-12-11  9:41       ` Andre Schwarz
2008-12-12 19:13         ` Jon Loeliger [this message]
2008-12-12 19:14         ` Jon Loeliger
2009-03-03  3:40         ` Jerry Van Baren
2009-03-03  9:12           ` Andre Schwarz
2008-12-11 11:06       ` Andre Schwarz
2008-12-12 19:16         ` Jon Loeliger
2008-12-08 20:01 ` Kim Phillips
2008-12-09 10:35   ` Andre Schwarz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4942B7F3.3000001@freescale.com \
    --to=jdl@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.