All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Switch to thread pool from posix-aio
Date: Fri, 12 Dec 2008 13:25:37 -0600	[thread overview]
Message-ID: <4942BAB1.7000208@codemonkey.ws> (raw)
In-Reply-To: <f43fc5580812121109t2c480930o446032d306363deb@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 625 bytes --]

Blue Swirl wrote:
> On 12/12/08, Anthony Liguori <anthony@codemonkey.ws> wrote:
>   
>> I've just committed the thread pool patch I posted a few days ago (plus the
>> suggested cleanups).
>>
>>  Please test this especially if you're using a very old glibc or a non-Linux
>> Unix.  Also pay attention for any performance differences.  I don't think
>> any will be noticable unless you're doing very heavy IO and I expect it will
>> only improve things.
>>     
>
> Compilation is broken on Debian stable, you need librt for
> timer_create, clock_gettime etc.
>   

Does this patch fix your problem?

Regards,

Anthony Liguori

[-- Attachment #2: rt-configure.patch --]
[-- Type: text/x-patch, Size: 779 bytes --]

diff --git a/configure b/configure
index d1f0c04..e997a32 100755
--- a/configure
+++ b/configure
@@ -972,6 +972,26 @@ if [ -x "`which texi2html 2>/dev/null`" ] && \
   build_docs="yes"
 fi
 
+##########################################
+# Do we need librt
+cat > $TMPC <<EOF
+#include <signal.h>
+#include <time.h>
+int main(void) { clockid_t id; return clock_gettime(id, NULL); }
+EOF
+
+rt=no
+if $cc $ARCH_CFLAGS -o $TMPE $TMPC 2> /dev/null ; then
+  :
+elif $cc $ARCH_CFLAGS -o $TMPE $TMPC -lrt 2> /dev/null ; then
+  rt=yes
+fi
+
+if test "$rt" = "yes" ; then
+  # Hack, we should have a general purpose LIBS for this sort of thing
+  AIOLIBS="$AIOLIBS -lrt"
+fi
+
 if test "$mingw32" = "yes" ; then
   if test -z "$prefix" ; then
       prefix="c:\\\\Program Files\\\\Qemu"

  parent reply	other threads:[~2008-12-12 19:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-12 16:43 [Qemu-devel] Switch to thread pool from posix-aio Anthony Liguori
2008-12-12 19:09 ` Blue Swirl
2008-12-12 19:20   ` Anthony Liguori
2008-12-12 19:25   ` Anthony Liguori [this message]
2008-12-12 20:00     ` Blue Swirl
2008-12-12 20:03       ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4942BAB1.7000208@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.