From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] netfilter: ctnetlink: fix missing CTA_NAT_SEQ_UNSPEC Date: Mon, 15 Dec 2008 13:12:10 +0100 Message-ID: <4946499A.5070503@trash.net> References: <20081210200649.23169.33618.stgit@Decadence> <49410EFF.1020603@trash.net> <494189BF.1040701@netfilter.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: netfilter-devel@vger.kernel.org To: Pablo Neira Ayuso Return-path: Received: from stinky.trash.net ([213.144.137.162]:54368 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751206AbYLOMMS (ORCPT ); Mon, 15 Dec 2008 07:12:18 -0500 In-Reply-To: <494189BF.1040701@netfilter.org> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Pablo Neira Ayuso wrote: > Patrick McHardy wrote: >> Pablo Neira Ayuso wrote: >>> This patch fixes an inconsistency in nfnetlink_conntrack.h that >>> I introduced myself. The problem is that CTA_NAT_SEQ_UNSPEC is >>> missing from enum ctattr_natseq. This inconsistency may lead to >>> problems in the message parsing in userspace (if the message >>> contains the CTA_NAT_SEQ_* attributes, of course). >>> >>> This patch breaks backward compatibility, however, the only known >>> client of this code is libnetfilter_conntrack which indeed crashes >>> because it assumes the existence of CTA_NAT_SEQ_UNSPEC to do >>> the parsing. >>> >>> The CTA_NAT_SEQ_* attributes were introduced in 2.6.25. >> Applied, thanks. > > Thanks Patrick. This one should go to 2.6.28 as bugfix I think. Do you > plan to pass it to David? Yes, I'll send it to Dave tonight.