All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: "Koskinen Aaro (NSN - FI/Helsinki)" <aaro.koskinen@nsn.com>
Cc: linux-scsi@vger.kernel.org, matthew@wil.cx
Subject: Re: [PATCH] sym53c8xx_2: lun to_clear flag not re-initialized (2.6.27.5)
Date: Mon, 15 Dec 2008 10:44:20 -0600	[thread overview]
Message-ID: <49468964.605@cs.wisc.edu> (raw)
In-Reply-To: <Pine.LNX.4.64.0811191525290.15796@fi-hi32-dhcp068123.emea.nsn-net.net>

Koskinen Aaro (NSN - FI/Helsinki) wrote:
> Fix for the sym53c8xx_2 driver to initialize lun's to_clear flag after
> a bus reset (a failed clear can trigger a bus reset and it should not
> be attemped again after that).
> 
> Signed-off-by: aaro.koskinen@nsn.com
> 

I think you just want to fix up your signed off line to be: 
Signed-off-by: Aaro Koskinen <aaro.koskinen@nsn.com>

James might to that for you when he merges it so you do not have to resend.


> ---
> 
> diff -uprN -X linux-2.6.27.5-orig/Documentation/dontdiff linux-2.6.27.5-orig/drivers/scsi/sym53c8xx_2/sym_hipd.c linux-2.6.27.5/drivers/scsi/sym53c8xx_2/sym_hipd.c
> --- linux-2.6.27.5-orig/drivers/scsi/sym53c8xx_2/sym_hipd.c	2008-11-07 19:55:34.000000000 +0200
> +++ linux-2.6.27.5/drivers/scsi/sym53c8xx_2/sym_hipd.c	2008-11-19 12:20:27.000000000 +0200
> @@ -1897,6 +1897,15 @@ void sym_start_up(struct Scsi_Host *shos
>  		tp->head.sval = 0;
>  		tp->head.wval = np->rv_scntl3;
>  		tp->head.uval = 0;
> +		if (tp->lun0p)
> +			tp->lun0p->to_clear = 0;
> +		if (tp->lunmp) {
> +			int ln;
> +
> +			for (ln = 1; ln < SYM_CONF_MAX_LUN; ln++)
> +				if (tp->lunmp[ln])
> +					tp->lunmp[ln]->to_clear = 0;
> +		}
>  	}
>  
>  	/*
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  reply	other threads:[~2008-12-15 16:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-19 13:34 [PATCH] sym53c8xx_2: lun to_clear flag not re-initialized (2.6.27.5) Koskinen Aaro (NSN - FI/Helsinki)
2008-12-15 16:44 ` Mike Christie [this message]
2008-12-16 16:19   ` Aaro Koskinen
  -- strict thread matches above, loose matches on Subject: below --
2008-12-29 20:55 [PATCH] sym53c8xx_2: slave_alloc/destroy safety (2.6.27.5) Tony Battersby
2008-12-30 10:10 ` Aaro Koskinen
2008-12-30 19:16   ` James Bottomley
2009-01-06 22:00     ` [PATCH] sym53c8xx_2: lun to_clear flag not re-initialized (2.6.27.5) Tony Battersby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49468964.605@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=aaro.koskinen@nsn.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.