From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Smart Date: Tue, 16 Dec 2008 15:32:24 +0000 Subject: Re: [PATCH 9/11] drivers/scsi: Move a dereference below a NULL test Message-Id: <4947CA08.4000606@emulex.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: "James.Bottomley@HansenPartnership.com" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" ACK -- james s Julia Lawall wrote: > From: Julia Lawall > > In each case, if the NULL test is necessary, then the dereference should be > moved below the NULL test. > > The semantic patch that makes this change is as follows: > (http://www.emn.fr/x-info/coccinelle/) > > // > @@ > type T; > expression E; > identifier i,fld; > statement S; > @@ > > - T i = E->fld; > + T i; > ... when != E > when != i > if (E = NULL) S > + i = E->fld; > // > > Signed-off-by: Julia Lawall > > --- > drivers/scsi/lpfc/lpfc_init.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c > index 909be33..9a01cf0 100644 > --- a/drivers/scsi/lpfc/lpfc_init.c > +++ b/drivers/scsi/lpfc/lpfc_init.c > @@ -1736,12 +1736,13 @@ lpfc_block_mgmt_io(struct lpfc_hba * phba) > int > lpfc_online(struct lpfc_hba *phba) > { > - struct lpfc_vport *vport = phba->pport; > + struct lpfc_vport *vport; > struct lpfc_vport **vports; > int i; > > if (!phba) > return 0; > + vport = phba->pport; > > if (!(vport->fc_flag & FC_OFFLINE_MODE)) > return 0; > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Smart Subject: Re: [PATCH 9/11] drivers/scsi: Move a dereference below a NULL test Date: Tue, 16 Dec 2008 10:32:24 -0500 Message-ID: <4947CA08.4000606@emulex.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from emulex.emulex.com ([138.239.112.1]:60698 "EHLO emulex.emulex.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755119AbYLPPbH (ORCPT ); Tue, 16 Dec 2008 10:31:07 -0500 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Julia Lawall Cc: "James.Bottomley@HansenPartnership.com" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" ACK -- james s Julia Lawall wrote: > From: Julia Lawall > > In each case, if the NULL test is necessary, then the dereference should be > moved below the NULL test. > > The semantic patch that makes this change is as follows: > (http://www.emn.fr/x-info/coccinelle/) > > // > @@ > type T; > expression E; > identifier i,fld; > statement S; > @@ > > - T i = E->fld; > + T i; > ... when != E > when != i > if (E == NULL) S > + i = E->fld; > // > > Signed-off-by: Julia Lawall > > --- > drivers/scsi/lpfc/lpfc_init.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c > index 909be33..9a01cf0 100644 > --- a/drivers/scsi/lpfc/lpfc_init.c > +++ b/drivers/scsi/lpfc/lpfc_init.c > @@ -1736,12 +1736,13 @@ lpfc_block_mgmt_io(struct lpfc_hba * phba) > int > lpfc_online(struct lpfc_hba *phba) > { > - struct lpfc_vport *vport = phba->pport; > + struct lpfc_vport *vport; > struct lpfc_vport **vports; > int i; > > if (!phba) > return 0; > + vport = phba->pport; > > if (!(vport->fc_flag & FC_OFFLINE_MODE)) > return 0; > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >