Avi Kivity wrote: > This makes several tons of sense, but breaks backwards compatibility. > If I understand correctly, get/set was never used so this shouldn't matter? > > I suggest reserving some space at the end of kvm_regs in case further > state needs to be added. > > Please add a KVM_CAP_ entry to advertise the fixup. This way userspace > can determine that it's compiling or running on an old kernel and error > out gracefully. Hi Avi, Here's an update version of this patch, which leaves some space for future extensions in struct kvm_regs. The KVM_CAP is unnecessary as GET/SET_REGS never worked on ia64. Cheers, Jes