All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: Markus Heidelberg <markus.heidelberg@web.de>,
	gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] Documentation: fix description for enabling hooks
Date: Wed, 17 Dec 2008 08:44:40 +0100	[thread overview]
Message-ID: <4948ADE8.2050804@viscovery.net> (raw)
In-Reply-To: <20081217041312.GZ5691@genesis.frugalware.org>

Miklos Vajna schrieb:
> On Wed, Dec 17, 2008 at 03:59:23AM +0100, Markus Heidelberg <markus.heidelberg@web.de> wrote:
>> Since f98f8cb (Ship sample hooks with .sample suffix, 2008-06-24) hooks
>> are not enabled by making them executable anymore, but by removing the
>> '.sample' suffix from the filename.
> 
> This is true, but having the executable bit is necessary as well. I
> think it would be better to just append this requirement instead of
> replacing the old one with this.

Markus's proposed new wording is correct because the .sample hooks *are*
already executable.

-- Hannes

  reply	other threads:[~2008-12-17  7:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-17  2:59 [PATCH] Documentation: fix description for enabling hooks Markus Heidelberg
2008-12-17  4:13 ` Miklos Vajna
2008-12-17  7:44   ` Johannes Sixt [this message]
2008-12-17 14:36     ` Miklos Vajna
2008-12-17 19:55       ` Markus Heidelberg
2008-12-17 21:29         ` [PATCH] githooks documentation: add a note about the +x mode Miklos Vajna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4948ADE8.2050804@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=markus.heidelberg@web.de \
    --cc=vmiklos@frugalware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.