All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Mark McLoughlin <markmc@redhat.com>, kvm-devel <kvm@vger.kernel.org>
Subject: Re: Loss of lock drop in qemu/net.c
Date: Wed, 17 Dec 2008 11:38:04 +0200	[thread overview]
Message-ID: <4948C87C.6060607@redhat.com> (raw)
In-Reply-To: <49480ED4.90900@codemonkey.ws>

Anthony Liguori wrote:
> Avi Kivity wrote:
>> hThe recent qemu merged does not allow net.h to include kvm code (due 
>> to a dependency on cpu.h).  This means I had to drop the 
>> kvm_sleep_begin()/kvm_sleep_end() around the packet send (which, btw, 
>> makes the whole thing vulnerable to hotunplug; we need refcounting or 
>> locking here).
>
> Why does net.h include cpu.h and why would net.h need kvm code?
>

I meant net.c -> qemu->kvm.h -> cpu.h.

The code in question is in net.c (in tap_send).

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2008-12-17  9:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-16 19:38 Loss of lock drop in qemu/net.c Avi Kivity
2008-12-16 20:25 ` Anthony Liguori
2008-12-17  9:38   ` Avi Kivity [this message]
2008-12-17  9:19 ` Mark McLoughlin
2008-12-17  9:39   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4948C87C.6060607@redhat.com \
    --to=avi@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=kvm@vger.kernel.org \
    --cc=markmc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.