From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <jbeulich@novell.com>
Subject: Re: [PATCH][RFC] Support S3 for MSI interrupt in latest
	kernel dom0
Date: Wed, 17 Dec 2008 15:31:06 +0000
Message-ID: <4949294A.76E4.0078.0@novell.com>
References: <49492679.76E4.0078.0@novell.com>
	<C56EC9A6.20575%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C56EC9A6.20575%keir.fraser@eu.citrix.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: Yunhong Jiang <yunhong.jiang@intel.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

>>> Keir Fraser <keir.fraser@eu.citrix.com> 17.12.08 16:22 >>>
>Well, maybe it's okay then. I don't think Yunhong's patch was a good
>argument for it -- looking again it appears to have plenty of not really
>related chunks contained in it.

I don't think it's really okay as-is: As he indicated, there may be side
effects of the changes during other than resume from S3 (in particular
the IRQ_GUEST check around the newly added call to ->startup()), and
I was hoping you might have a suggestion on how to better distinguish
that particular case. In the worst case, Xen has to set another flag in
each MSI irq_desc when it resumes from S3, and do the startup as well
as the clearing of the flag when map_domain_pirq runs first for that
particular vector.

Jan