All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: wireless <linux-wireless@vger.kernel.org>
Subject: [RFC] mac80211: Print unknown packet type
Date: Wed, 17 Dec 2008 12:27:57 -0600	[thread overview]
Message-ID: <494944AD.7020204@lwfinger.net> (raw)

Johannes,

I'm trying to find a problem with p54usb that causes it to go belly-up under
stress testing. In one of my runs, I hit the WARN_ON in
ieee80211_tasklet_handler(). Unfortunately, I got no indication of what was in
skb->pkt_type, just that it was not one of the expected types.

Do you think that adding the printk below would be worthwhile?

Thanks,

Larry
---

Index: wireless-testing/net/mac80211/main.c
===================================================================
--- wireless-testing.orig/net/mac80211/main.c
+++ wireless-testing/net/mac80211/main.c
@@ -341,6 +341,8 @@ static void ieee80211_tasklet_handler(un
 			dev_kfree_skb(skb);
 			break ;
 		default:
+			printk(KERN_INFO "mac80211: Packet is of unknown type"
+					 " %d\n", skb->pkt_type);
 			WARN_ON(1);
 			dev_kfree_skb(skb);
 			break;



             reply	other threads:[~2008-12-17 18:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-17 18:27 Larry Finger [this message]
2008-12-17 18:15 ` [RFC] mac80211: Print unknown packet type Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=494944AD.7020204@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.