From: Sakari Ailus <sakari.ailus@iki.fi>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 0/2] tlan: fix earlier fixes, remove big buffer mode
Date: Wed, 17 Dec 2008 23:26:39 +0200 [thread overview]
Message-ID: <49496E8F.1000207@iki.fi> (raw)
In-Reply-To: <20081216.152215.48045394.davem@davemloft.net>
David Miller wrote:
> From: Sakari Ailus <sakari.ailus@iki.fi>
> Date: Tue, 16 Dec 2008 17:24:50 +0200
>
>> Unfortunately it seems that my last patch introduced a few problems.
>>
>> So here are two patches: the first one fixes the pci memory
>> unmapping. The second one removes the big buffer mode.
>
> I think what I'm going to do is put your first patch into
> net-2.6 and the bigbuf removal into net-next-2.6
Sounds good, thanks!
> Yes I realize that your changes might have made bigbuf even
> more broken than it already is, that's fine since it's
> off by default.
On second though, I don't think the bbuf mode was broken by my patches
more than it already was. skb_copy_from_linear_data copies txlen bytes
from skb->data to tail_buffer. This is fine, since the skb has at least
that many bytes and tail_buffer is at least as big, too. One should
never make this kind of claims when too tired... ;)
But the bottom line is still that the bbuf mode doesn't work.
--
Sakari Ailus
sakari.ailus@iki.fi
prev parent reply other threads:[~2008-12-17 21:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 15:24 [PATCH 0/2] tlan: fix earlier fixes, remove big buffer mode Sakari Ailus
2008-12-16 15:25 ` [PATCH 1/2] tlan: Fix pci memory unmapping Sakari Ailus
2008-12-16 15:25 ` [PATCH 2/2] tlan: Remove broken support for big buffers Sakari Ailus
2008-12-16 23:22 ` [PATCH 0/2] tlan: fix earlier fixes, remove big buffer mode David Miller
2008-12-17 21:26 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49496E8F.1000207@iki.fi \
--to=sakari.ailus@iki.fi \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.