All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mingo@elte.hu, viro@ftp.linux.org.uk,
	linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
	alex.zeffertt@eu.citrix.com, Ian.Campbell@citrix.com
Subject: Re: [PATCH UPDATED] xen: add xenfs to allow usermode <-> Xen interaction
Date: Wed, 17 Dec 2008 13:50:52 -0800	[thread overview]
Message-ID: <4949743C.2040306@goop.org> (raw)
In-Reply-To: <20081217133429.b64e6421.akpm@linux-foundation.org>

Andrew Morton wrote:
> I'm bored of your filesystem, so I think I'll just merge it, unless
> someone else wants to ;)
>   

Yay!  Boring code Wins!

> Was this noticed and considered?
>
> WARNING: consider using strict_strtoul in preference to simple_strtoul
> #543: FILE: drivers/xen/xenfs/xenbus.c:315:
> +               trans->handle.id = simple_strtoul(reply, NULL, 0);
>   

Noticed that, but wasn't sure how to handle an error there anyway.  
Something pretty horrible must have happened at the other end.

    J

  reply	other threads:[~2008-12-17 21:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-16 20:27 [PATCH] xen: add xenfs to allow usermode <-> Xen interaction Jeremy Fitzhardinge
2008-12-16 20:46 ` Ingo Molnar
2008-12-16 20:54 ` Andrew Morton
2008-12-16 22:43   ` Jeremy Fitzhardinge
2008-12-17 21:24   ` [PATCH UPDATED] " Jeremy Fitzhardinge
2008-12-17 21:34     ` Andrew Morton
2008-12-17 21:50       ` Jeremy Fitzhardinge [this message]
2008-12-18 13:18       ` Ingo Molnar
2008-12-17 21:40     ` [PATCH UPDATED] xen/xenfs: fix xenbus message reads Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4949743C.2040306@goop.org \
    --to=jeremy@goop.org \
    --cc=Ian.Campbell@citrix.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex.zeffertt@eu.citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=viro@ftp.linux.org.uk \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.