All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Daney <ddaney@caviumnetworks.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: linux-mips@linux-mips.org
Subject: Re: N32 fallocate syscall
Date: Wed, 17 Dec 2008 17:43:24 -0800	[thread overview]
Message-ID: <4949AABC.2070507@caviumnetworks.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0812180009000.31179@digraph.polyomino.org.uk>

Joseph S. Myers wrote:
> The N32 syscall table uses sys_fallocate instead of sys32_fallocate.  
> However, glibc expects to be using the syscall version with 32-bit 
> arguments on N32, which should work with sys32_fallocate but not 
> sys_fallocate.
> 
> What should the N32 interface for this syscall be?  My inclination is that 
> glibc is right not to do anything special and different from other 32-bit 
> ABIs here, and so sys32_fallocate should be used.
> 

The prototype for that would be something like:

sys_fallocate(int32_t, int32_t, int64_t, int64_t);

The N32 and N64 ABIs treat this identically, the parameters are passed
in a0, a1, a2, and a3.  As you noted, the current (2.6.28-rc8) kernel
sources follow the ABI for N32 and N64.  I think the kernel is
correct.

If glibc is not using the ABI calling convention for both N32 and N64 (I
haven't checked), it should probably be fixed.

> (glibc is also expecting the 32-bit version for N64, but that's a clear 
> bug in glibc that I'll be fixing.)
> 

David Daney

  reply	other threads:[~2008-12-18  1:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-18  0:14 N32 fallocate syscall Joseph S. Myers
2008-12-18  1:43 ` David Daney [this message]
2008-12-18  7:10 ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4949AABC.2070507@caviumnetworks.com \
    --to=ddaney@caviumnetworks.com \
    --cc=joseph@codesourcery.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.