From: "Jan Beulich" <jbeulich@novell.com>
To: Juergen Gross <juergen.gross@fujitsu-siemens.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [Patch 2 of 2]: PV-domain SMP performance Linux-part
Date: Thu, 18 Dec 2008 07:41:57 +0000 [thread overview]
Message-ID: <494A0CD5.76E4.0078.0@novell.com> (raw)
In-Reply-To: <4949F950.80509@fujitsu-siemens.com>
>>> Juergen Gross <juergen.gross@fujitsu-siemens.com> 18.12.08 08:18 >>>
>Jan Beulich wrote:
>>
>>> + _vcpu->no_desched = 0; \
>>> + _vcpu->evtchn_upcall_mask = 0; \
>>> barrier(); /* unmask then check (avoid races) */ \
>>> + if ( unlikely(_vcpu->desched_delay) ) \
>>> + (void)((HYPERVISOR_sched_op(SCHEDOP_yield, _vcpu))?:0); \
>>
>> Why not just cast the function result to void? Likewise further below...
>
>I took that from include/xen/hypercall.h, which mentioned problems with just
>casting the function result.
Ah, yes, I recall. But then why don't you use that macro? After all, hypercall.h
must have been included if you're able to call HYPERVISOR_sched_op().
Jan
next prev parent reply other threads:[~2008-12-18 7:41 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 12:22 [Patch 2 of 2]: PV-domain SMP performance Linux-part Juergen Gross
2008-12-17 15:06 ` Jan Beulich
2008-12-18 7:18 ` Juergen Gross
2008-12-18 7:41 ` Jan Beulich [this message]
2008-12-19 8:12 ` Juergen Gross
2008-12-19 9:10 ` Keir Fraser
2008-12-19 9:25 ` Juergen Gross
2008-12-19 9:56 ` Keir Fraser
2009-01-16 7:16 ` Juergen Gross
2009-01-16 7:38 ` Venefax
2009-01-16 7:48 ` Juergen Gross
2009-01-16 7:57 ` Venefax
2009-01-16 8:19 ` Juergen Gross
2009-01-16 10:16 ` James Harper
2009-01-16 10:31 ` Juergen Gross
2009-01-16 10:41 ` Keir Fraser
2009-01-16 11:01 ` James Harper
2009-01-16 11:14 ` Keir Fraser
2009-01-16 11:18 ` Jan Beulich
2009-01-16 14:40 ` Steve Prochniak
2009-01-16 17:43 ` Jeremy Fitzhardinge
2009-01-16 8:17 ` Keir Fraser
2009-01-16 9:36 ` Juergen Gross
2009-01-16 9:53 ` Keir Fraser
2009-01-16 17:41 ` Jeremy Fitzhardinge
2009-01-19 17:15 ` George Dunlap
2009-01-20 20:12 ` Jeremy Fitzhardinge
2008-12-19 9:33 ` Jan Beulich
2008-12-19 9:56 ` Keir Fraser
2008-12-19 15:15 ` George Dunlap
2009-01-12 12:55 ` Juergen Gross
2009-01-19 17:32 ` George Dunlap
2009-01-20 7:56 ` Juergen Gross
2008-12-19 10:06 ` Juergen Gross
2008-12-19 10:36 ` Jan Beulich
2008-12-19 10:42 ` Juergen Gross
2008-12-19 10:48 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494A0CD5.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=juergen.gross@fujitsu-siemens.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.