From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Thu, 18 Dec 2008 11:19:30 +0000 Subject: Re: [patch] fix kvm_arch_vcpu_ioctl_[gs]et_regs() - v2 Message-Id: <494A31C2.4060304@redhat.com> List-Id: References: <4947CD2B.5030300@sgi.com> In-Reply-To: <4947CD2B.5030300@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org Jes Sorensen wrote: > Avi Kivity wrote: >> Jes Sorensen wrote: >>> >>> Please don't do that, then they'll end up after a 16KB struct, I put >>> them where they were deliberately. >> Why does it matter? I don't see any performance issue, we copy >> everything anyway, and this is not a high usage interface. > > Well it just makes the generated code uglier. > Who cares? -- error compiling committee.c: too many arguments to function