From mboxrd@z Thu Jan  1 00:00:00 1970
From: Akio Takebe <takebe_akio@jp.fujitsu.com>
Subject: Re: [Patch][RFC] Update rombios.c
Date: Thu, 18 Dec 2008 22:27:39 +0900
Message-ID: <494A4FCB.6080200@jp.fujitsu.com>
References: <494911BB.8040506@jp.fujitsu.com>
	<20081218111810.GM460@york.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20081218111810.GM460@york.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Tim Deegan <Tim.Deegan@citrix.com>
Cc: Juergen Keil <jk@tools.de>, Steve Ofsthun <sofsthun@virtualiron.com>, xen-devel@lists.xensource.com, Stefan Berger <stefanb@us.ibm.com>, Bruce Rogers <brogers@novell.com>, Ke Liping <liping.ke@intel.com>, Yu Ke <ke.yu@intel.com>, Travis Betak <travis.betak@amd.com>, "Daniel P. Berrange" <berrange@redhat.com>, Keir Fraser <keir.fraser@citrix.com>, Seiji Munetoh <seiji.munetoh@gmail.com>
List-Id: xen-devel@lists.xenproject.org

Tim Deegan wrote:
> Hi,
> 
> At 23:50 +0900 on 17 Dec (1229557835), Akio Takebe wrote:
>> This patch update rombios to the latest Bochs's.
>> I'd like to corabolate bochs community to enhance the guest bios.
>> I'm not familiar around TCGBIOS.
>> So could you review the patch?
>>
>> I tested boot/shutdown, S3 suspend/resume with linux guest.
>> Any comments are welcome :-)
> 
> Does the boot-options menu work properly after the patch?  This bit of
> code looks suspect to me; surely some more translation is necessary to
> turn a scan code into an offset into the boot device table:
> 
> +      while (!valid_choice) {
> +        scan_code = get_keystroke();
> +        if (scan_code == 0x01 || scan_code == 0x58) /* ESC or F12 */
> +        {
> +          valid_choice = 1;
> +        }
> +        else if (scan_code <= count)
> +        {
> +          valid_choice = 1;
> +          scan_code -= 1;
> +          /* Set user selected device */
> +          write_word(ebda_seg, IPL_BOOTFIRST_OFFSET, scan_code);
> +        }
> +      }
> 
Thank you for your review.
I used the bochs upstream code instead of xen's
because I want to use the upstream code.
It works fine. The scan_codes are below.
http://www.arl.wustl.edu/~lockwood/class/cs306/books/artofasm/APNDXC.PDF

> Otherwise, this patch looks good to me, though it's enormous so I
> haven't looked at every detail.
> 
> Also: does this update mean that the Xen rombios now has two separate
> 32-bit extensions?  Might it be worth using the upstream one instead of
> maintaining our own?
> 
I added "#define LAGACY" in rombios.h
So the patch uses Xen's 32bit extentions.
As you said, using the upstream one may be better.
But merging the upstream's 32bits extentions looks difficult
because xen initialize some parts of BIOS data in hvmloader.

Best Regards,

Akio Takebe