All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akio Takebe <takebe_akio@jp.fujitsu.com>
To: xen-devel <xen-devel@lists.xensource.com>
Subject: [Patch] avoid unnecessary loading NIC rom.
Date: Thu, 18 Dec 2008 22:45:57 +0900	[thread overview]
Message-ID: <494A5415.6020907@jp.fujitsu.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Hi,

When we don't specify PXE boot in guest configuration file,
it is not necessary for hvmloader to load PXE option ROM.
This patch avoid unncessary loading the rom.
It can save shadow memory area for option ROMs.

Signed-off-by: Akio Takebe <takebe_akio@jp.fujitsu.com>

Best Regards,

Akio Takebe

[-- Attachment #2: avoid_unnecessary_rom_loading.patch --]
[-- Type: text/x-diff, Size: 1654 bytes --]

diff -r a76b4e00e186 tools/firmware/hvmloader/hvmloader.c
--- a/tools/firmware/hvmloader/hvmloader.c	Tue Dec 16 13:14:25 2008 +0000
+++ b/tools/firmware/hvmloader/hvmloader.c	Thu Dec 18 22:38:18 2008 +0900
@@ -423,19 +423,28 @@
 {
     uint8_t devfn;
     uint16_t class, vendor_id, device_id;
+    uint16_t bootdev;
+    uint16_t seq_nr;
 
-    for ( devfn = 0; devfn < 128; devfn++ )
-    {
-        class     = pci_readw(devfn, PCI_CLASS_DEVICE);
-        vendor_id = pci_readw(devfn, PCI_VENDOR_ID);
-        device_id = pci_readw(devfn, PCI_DEVICE_ID);
+    for (seq_nr=0; seq_nr<3; seq_nr++ ){
+        bootdev = cmos_inb(0x3d);
+        bootdev |= ((cmos_inb(0x38) & 0xf0) << 4);
+        bootdev >>= 4 * seq_nr;
+        bootdev &= 0xf;
+	if ( bootdev == 4 ){
+            for ( devfn = 0; devfn < 128; devfn++ ){
+                class     = pci_readw(devfn, PCI_CLASS_DEVICE);
+                vendor_id = pci_readw(devfn, PCI_VENDOR_ID);
+                device_id = pci_readw(devfn, PCI_DEVICE_ID);
 
-        /* We're only interested in NICs. */
-        if ( (vendor_id != 0xffff) &&
-             (device_id != 0xffff) &&
-             (class == 0x0200) )
-            return scan_option_rom(
-                devfn, vendor_id, device_id, etherboot, copy_rom_dest);
+                /* We're only interested in NICs. */
+                if ( (vendor_id != 0xffff) &&
+                     (device_id != 0xffff) &&
+                     (class == 0x0200) )
+                    return scan_option_rom(devfn, vendor_id, 
+                               device_id, etherboot, copy_rom_dest);
+            }
+        }
     }
 
     return 0;

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

             reply	other threads:[~2008-12-18 13:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-18 13:45 Akio Takebe [this message]
2008-12-18 14:40 ` [Patch] avoid unnecessary loading NIC rom Keir Fraser
2008-12-18 14:50   ` Akio Takebe
2008-12-18 14:55     ` Keir Fraser
2008-12-18 15:00       ` Keir Fraser
2008-12-19  7:37         ` Akio Takebe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=494A5415.6020907@jp.fujitsu.com \
    --to=takebe_akio@jp.fujitsu.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.