From: Paul Clements <paul.clements@steeleye.com>
To: Pavel Machek <pavel@suse.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: nbd: clean up error handling
Date: Thu, 18 Dec 2008 14:15:39 -0500 [thread overview]
Message-ID: <494AA15B.2010000@steeleye.com> (raw)
In-Reply-To: <20081218182108.GA13546@elf.ucw.cz>
Hi Pavel,
hanks for the patch...
Pavel Machek wrote:
> Uses existing error_out: label instead of hardcoding error action.
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
> @@ -475,8 +473,7 @@ static void nbd_handle_req(struct nbd_de
> if (nbd_send_req(lo, req) != 0) {
> printk(KERN_ERR "%s: Request send failed\n",
> lo->disk->disk_name);
> - req->errors++;
> - nbd_end_request(req);
> + goto error_out;
This one is not correct. We don't return immediately here.
--
Paul
next prev parent reply other threads:[~2008-12-18 19:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 18:21 nbd: clean up error handling Pavel Machek
2008-12-18 19:15 ` Paul Clements [this message]
2008-12-28 8:03 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494AA15B.2010000@steeleye.com \
--to=paul.clements@steeleye.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.