All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Li Zefan <lizf@cn.fujitsu.com>, Paul Menage <menage@google.com>,
	linux-kernel@vger.kernel.org,
	Dhaval Giani <dhaval@linux.vnet.ibm.com>,
	Sudhir Kumar <skumar@linux.vnet.ibm.com>,
	Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
	Bharata B Rao <bharata.rao@in.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	libcg-devel <libcg-devel@lists.sourceforge.net>
Subject: Re: [BUG][PANIC] cgroup panics with mmotm for 2.6.28-rc7
Date: Fri, 19 Dec 2008 08:53:25 +0800	[thread overview]
Message-ID: <494AF085.3000802@cn.fujitsu.com> (raw)
In-Reply-To: <20081218191839.GI26572@balbir.in.ibm.com>

>>>>> kernel BUG at kernel/cgroup.c:392!
>> In latest -mm, this BUG_ON is line 398, and before the below 2 fixlet patches,
>> the BUG_ON is line 392, so I guess you were using older -mm:
>>
>> cgroups-add-inactive-subsystems-to-rootnodesubsys_list-fix.patch
>> cgroups-introduce-link_css_set-to-remove-duplicate-code-fix.patch
>>
>> Could you try the latest -mm kernel, or apply
>> cgroups-add-inactive-subsystems-to-rootnodesubsys_list-fix.patch ?
>>
>> diff -puN kernel/cgroup.c~cgroups-add-inactive-subsystems-to-rootnodesubsys_list-fix kernel/cgroup.c
>> --- a/kernel/cgroup.c~cgroups-add-inactive-subsystems-to-rootnodesubsys_list-fix
>> +++ a/kernel/cgroup.c
>> @@ -2521,7 +2521,7 @@ static void __init cgroup_init_subsys(st
>>  	printk(KERN_INFO "Initializing cgroup subsys %s\n", ss->name);
>>
>>  	/* Create the top cgroup state for this subsystem */
>> -	list_add(&ss->sibling, &rootnode.root_list);
>> +	list_add(&ss->sibling, &rootnode.subsys_list);
>>  	ss->root = &rootnode;
>>  	css = ss->create(ss, dummytop);
>>  	/* We don't handle early failures gracefully */
>>
> 
> Yes, this fix does work for me,
>  

Thanks! And sorry for the silly mistake I made.


      reply	other threads:[~2008-12-19  0:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-15 11:32 [BUG][PANIC] cgroup panics with mmotm for 2.6.28-rc7 Balbir Singh
2008-12-16  1:57 ` Paul Menage
2008-12-16  1:58   ` Paul Menage
2008-12-16  2:41   ` Li Zefan
2008-12-16  2:53     ` Li Zefan
2008-12-16  3:52       ` Balbir Singh
2008-12-18 19:18       ` Balbir Singh
2008-12-19  0:53         ` Li Zefan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=494AF085.3000802@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=bharata.rao@in.ibm.com \
    --cc=dhaval@linux.vnet.ibm.com \
    --cc=libcg-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    --cc=skumar@linux.vnet.ibm.com \
    --cc=vatsa@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.