Re: [PATCH 1/8] ALSA: ASoC: tlv320aic3x add dsp_a, fix dsp_b

[Troy Kisky <troy.kisky@boundarydevices.com>]

Jarkko Nikula wrote:
> On Thu, Dec 18, 2008 at 9:36 PM, Troy Kisky
> <troy.kisky@boundarydevices.com>wrote:
> 
>> Add SND_SOC_DAIFMT_DSP_A and fix SND_SOC_DAIFMT_DSP_B
>> mode. Before dsp_b was really being initialized as dsp_a.
>>
>> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
>>
> 
> 
>> @@ -873,6 +874,8 @@ static int aic3x_set_dai_fmt(struct snd_soc_dai
>> *codec_dai,
>>        case (SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF):
>>                break;
>>        case (SND_SOC_DAIFMT_DSP_B | SND_SOC_DAIFMT_IB_NF):
>> +               delay = 1;
>> +       case (SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_IB_NF):
>>                iface_breg |= (0x01 << 6);
>>                break;
>>
> 
> Is this correct? I'm looking the WM9713 spec and there DSP_A has the 1-bit
> delay.
> 
> But I like this idea to add another DSP format.
> 
> 
> Jarkko

I think you are correct. Thanks.

But, the AIC23 and SSM2602 would then be backwards too.


Troy