All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH] hwmon: Add a driver for the ADT7475 thermal
Date: Fri, 19 Dec 2008 21:32:21 +0000	[thread overview]
Message-ID: <494C12E5.8000102@redhat.com> (raw)
In-Reply-To: <20080610194818.GA21150@cosmic.amd.com>

p.s.

This has been tested on my Asus M2N SLI deluxe motherboard


Hi Jean,

As Jordan did not get around to doing this and the 2.6.29 merge window is near
I've fixed the last few outstanding issues from my review(s) of his adt7475
I've done myself. Attached is a new version of the adt7475 with:
* all issues review found fixed
* converted to the new i2c driver style
* a few more registers needed reading in store methods
* corrected register to voltage conversion (more accurate)
* some style fixes
* locking around show functions where the value shown depends on more then
    1 reg.
* read limit registers only once every 60 seconds
* rename pwm_min and pwm_max to pwm_auto_pointX_pwm, as the
    control the scope between which the pwm gets changed in auto mode
* remove tempX_crit_alarm (only one crit alarm flag for all 3 channels)

I hope this is ok now to be queued for 2.6.29

Thanks & Regards,

Hans


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2008-12-19 21:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-10 19:48 [lm-sensors] [PATCH] hwmon: Add a driver for the ADT7475 thermal Jordan Crouse
2008-06-13  7:10 ` [lm-sensors] [PATCH] hwmon: Add a driver for the ADT7475 Matt Roberds
2008-08-07 20:56 ` Hans de Goede
2008-09-05 20:54 ` [lm-sensors] [PATCH] hwmon: Add a driver for the ADT7475 thermal Jordan Crouse
2008-09-06 10:00 ` [lm-sensors] [PATCH] hwmon: Add a driver for the ADT7475 Hans de Goede
2008-12-19 21:31 ` [lm-sensors] [PATCH] hwmon: Add a driver for the ADT7475 thermal Hans de Goede
2008-12-19 21:32 ` Hans de Goede [this message]
2008-12-19 23:46 ` [lm-sensors] [PATCH] hwmon: Add a driver for the ADT7475 Matt Roberds
2008-12-20  8:16 ` Hans de Goede
2008-12-20  8:22 ` [lm-sensors] [PATCH] hwmon: Add a driver for the ADT7475 thermal Hans de Goede
2008-12-22 23:23 ` [lm-sensors] [PATCH] hwmon: Add a driver for the ADT7475 Jordan Crouse
2008-12-23 18:38 ` Matt Roberds
2009-01-04 17:57 ` Daimonos Tereutes
2009-01-07 21:52 ` Jean Delvare
2009-01-08  7:56 ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=494C12E5.8000102@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.