From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LEhDa-0003Hi-73
	for qemu-devel@nongnu.org; Mon, 22 Dec 2008 04:36:54 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LEhDY-0003HS-1W
	for qemu-devel@nongnu.org; Mon, 22 Dec 2008 04:36:53 -0500
Received: from [199.232.76.173] (port=55253 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LEhDX-0003HO-Rc
	for qemu-devel@nongnu.org; Mon, 22 Dec 2008 04:36:51 -0500
Received: from outbound-va3.frontbridge.com ([216.32.180.16]:11016
	helo=VA3EHSOBE005.bigfish.com)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_MD5:16)
	(Exim 4.60) (envelope-from <Andre.Przywara@amd.com>)
	id 1LEhDW-0007My-TK
	for qemu-devel@nongnu.org; Mon, 22 Dec 2008 04:36:51 -0500
Message-ID: <494F5F9E.1020801@amd.com>
Date: Mon, 22 Dec 2008 10:36:30 +0100
From: Andre Przywara <andre.przywara@amd.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] add missing firmware configuration channel
	numbers to BIOS
References: <494ED60F.6000509@amd.com>
	<f43fc5580812212229q6bc10785ne84768f99e479383@mail.gmail.com>
In-Reply-To: <f43fc5580812212229q6bc10785ne84768f99e479383@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Blue Swirl wrote:
>>
>>  although we currently don't use firmware config channel
>>  numbers higher than '0x02' in the PC-BIOS, add the channel
>>  names to the BIOS source to mark already used entries.
>>  This will make picking new number easier in the future.
> 
> Isn't it possible to use fw_cfg.h directly? To get just the constants,
> you can use NO_QEMU_PROTOS.
Nice idea, but this would require to have the QEMU sources directly 
available when building the BIOS ROM. This is not a real problem, but 
would require to pull in the QEMU source path from the BOCHS autotools 
Makefile (with what default? Revert to the current code if no QEMU 
source path is given?). Currently you can build the BIOS independently 
with just the QEMU patches applied. If you (or Anthony) think this OK, 
I'd prepare a patch for this.

Regards,
Andre.

> 
> This is how it is used in OpenBIOS/Sparc64 as an example:
> 
> http://tracker.coreboot.org/trac/openbios/browser/openbios-devel/arch/sparc64/entry.S#L14
> 
> http://tracker.coreboot.org/trac/openbios/browser/openbios-devel/arch/sparc64/openbios.c#L29
>