From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: RE: [PATCH] Revert Jan's patch (c/s 18879) since now itcanbe achieved by xenpm tool now Date: Mon, 22 Dec 2008 10:12:42 +0000 Message-ID: <494F762A.76E4.0078.0@novell.com> References: <706158FABBBA044BAD4FE898A02E4BC21C7FD572@pdsmsx503.ccr.corp.intel.com> <494F63F5.76E4.0078.0@novell.com> <706158FABBBA044BAD4FE898A02E4BC21C7FD9B7@pdsmsx503.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC21C7FD9B7@pdsmsx503.ccr.corp.intel.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jinsong Liu Cc: "xen-devel@lists.xensource.com" , Keir Fraser List-Id: xen-devel@lists.xenproject.org >>> "Liu, Jinsong" 22.12.08 10:40 >>> >Jan Beulich wrote: >>>>> "Liu, Jinsong" 20.12.08 14:37 >>> >>> Revert Jan's patch (c/s 18879) since now it can be achieved by >>> xenpm tool now. >>=20 >> Please don't, and rather (as Keir suggested) add an option to also >> select the initial governor on the command line. While the xenpm tool >> is nice, older distro-s won't run it by default, and having to fiddle >> with the system startup scripts or running it manually (which >> wouldn't necessarily work if you don't do a full install of the Xen >> tool - e.g. to keep the distro's tools intact) isn't really desirable >> in certain cases.=20 >>=20 >> Jan > >Jan, > >It's good for old distro-s user to use cmdline to set parameter, but I = have >some concern, since in fact cpufreq have 5 governors, with ~20 status >parameters and ~10 control parameters. If we add option at grub >cmdline to select initial governor, and add further options to set = control >parameters, it may make confuse for user, especially considered that >some of the control parameters are governor-dependent (i.e. in c/s >18879, the control para 'sample rate' and 'upthreshold' can only be used >for ondemand or conservative governor). User may confuse what the Which is why they are being parsed in the ondemand governor's source file... >default governor is, and what control parameters can be used at grub >cmdline for that governor. Anything not applicable would be ignored. I don't think there's much confusion associated with this. Jan