From: Lachlan McIlroy <lachlan@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] handle unaligned data in xfs_bmbt_disk_get_all
Date: Tue, 23 Dec 2008 11:45:09 +1100 [thread overview]
Message-ID: <49503495.1050207@sgi.com> (raw)
In-Reply-To: <20081222145906.GA18859@infradead.org>
Looks good.
Christoph Hellwig wrote:
> In libxfs xfs_bmbt_disk_get_all needs to handle unaligned data and thus
> has been updated to use get_unaligned_be64. In kernelspace we don't strictly
> need it as the routine is only used for tracing and xfsidbg, but let's keep
> the two implementations in sync.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfs/fs/xfs/xfs_bmap_btree.c
> --- xfs.orig/fs/xfs/xfs_bmap_btree.c 2008-12-19 15:02:53.998907997 +0100
> +++ xfs/fs/xfs/xfs_bmap_btree.c 2008-12-22 14:43:41.507247175 +0100
> @@ -208,7 +208,8 @@ xfs_bmbt_disk_get_all(
> xfs_bmbt_rec_t *r,
> xfs_bmbt_irec_t *s)
> {
> - __xfs_bmbt_get_all(be64_to_cpu(r->l0), be64_to_cpu(r->l1), s);
> + __xfs_bmbt_get_all(get_unaligned_be64(&r->l0),
> + get_unaligned_be64(&r->l1), s);
> }
>
> /*
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2008-12-23 0:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-22 14:59 [PATCH] handle unaligned data in xfs_bmbt_disk_get_all Christoph Hellwig
2008-12-23 0:45 ` Lachlan McIlroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49503495.1050207@sgi.com \
--to=lachlan@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.