From: "Jan Beulich" <jbeulich@novell.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>,
Jinsong Liu <jinsong.liu@intel.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] Revert Jan's patch (c/s 18879) since nowitcanbe achieved by xenpm tool now
Date: Tue, 23 Dec 2008 09:34:42 +0000 [thread overview]
Message-ID: <4950BEC2.76E4.0078.0@novell.com> (raw)
In-Reply-To: <C5765A8E.20861%keir.fraser@eu.citrix.com>
>>> Keir Fraser <keir.fraser@eu.citrix.com> 23.12.08 10:06 >>>
>On 23/12/2008 09:02, "Liu, Jinsong" <jinsong.liu@intel.com> wrote:
>
>> It's fine to me to keep cmdline parse to select cpufreq governor.
>> I will update my patch, final result is:
>> 1. keep Jan's patch (c/s 18879);
>> 2. add governor setting at cmdline;
>> 3. set xen as default cpufreq;
>> 4. set userspace as default governor;
>> 5. if user set governor at cmdline --> if gov startup success, then cpufreq
>> run it; if gov startup fail, then cpufreq back to default safe governor;
>> Is it OK?
>
>Sounds fine to me. Let's see what Jan thinks too.
I'm okay with this too, though I'm not entirely clear why the userspace
governor would be safer/better than the performance one (in particular,
I'm unclear why the latter - supposedly not playing with frequencies at
all - has dependencies on certain tables to be loaded successfully). But
I admit that I didn't get around to look at the recent code changes, yet.
Jan
prev parent reply other threads:[~2008-12-23 9:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-20 13:37 [PATCH] Revert Jan's patch (c/s 18879) since now it can be achieved by xenpm tool now Liu, Jinsong
2008-12-22 8:55 ` [PATCH] Revert Jan's patch (c/s 18879) since now it canbe " Jan Beulich
2008-12-22 9:40 ` Liu, Jinsong
2008-12-22 10:12 ` [PATCH] Revert Jan's patch (c/s 18879) since now itcanbe " Jan Beulich
2008-12-23 2:29 ` Liu, Jinsong
2008-12-23 8:38 ` Keir Fraser
2008-12-23 9:02 ` Liu, Jinsong
2008-12-23 9:06 ` Keir Fraser
2008-12-23 9:34 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4950BEC2.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=jinsong.liu@intel.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.