All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lachlan McIlroy <lachlan@sgi.com>
To: Niv Sardi <xaiki@cxhome.ath.cx>
Cc: Christoph Hellwig <hch@infradead.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [Fwd: [PATCH] Fix race in xfs_write() between direct and	buffered I/O with DMAPI]
Date: Wed, 24 Dec 2008 13:23:20 +1100	[thread overview]
Message-ID: <49519D18.3080307@sgi.com> (raw)
In-Reply-To: <87wsdq727n.fsf@cxhome.ath.cx>

Niv Sardi wrote:
> Lachlan McIlroy <lachlan@sgi.com> writes:
> 
>> Christoph Hellwig wrote:
>>
>>> On Tue, Dec 23, 2008 at 11:40:24AM +1100, Lachlan McIlroy wrote:
>>>> Christoph Hellwig wrote:
>>>>> Do you need more input on this one?
>>>> Actually I just might.  Based on your last reponse I wasn't sure if
>>>> you wanted me to make further changes.
>>> Well, my reponse was that I think we could do it more effecient, but the
>>> patch still looks correct to me.
>> Okay great.  I'll check it in and we can improve it later when I understand
>> what you meant!
>>
>>>> Then I got side-tracked wondering
>>>> why we even have the 'goto retry' in the dmapi post event - why retry the
>>>> write if we get ENOSPC when we don't if dmapi is not enabled?  Could the
>>>> write get stuck in an infinite loop?
>>> We only retry on ENOSPC if the dmapi nospace even is enabled, or am I
>>> missing something?
>> I don't think you're missing anything here.  I don't understand how the
>> DMAPI stuff works but I imagined the event was there to indicate that the
>> write failed but what I don't understand is why that justifies a retry.
>> Is there something about DMAPI that needs the write to succeed?
> 
> yes
> 
> http://www.opengroup.org/onlinepubs/9657099/chap3.htm#tagcjh_04_02_04
Oh no, not the DMAPI spec - I don't want to go there!  Sounds like the
XFS_SEND_NAMESP() event can choose to fail and that will prevent an
infinite loop.  Thanks Niv.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2008-12-24  2:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-04  6:33 [Fwd: [PATCH] Fix race in xfs_write() between direct and buffered I/O with DMAPI] Lachlan McIlroy
2008-12-08 22:51 ` Christoph Hellwig
2008-12-09  5:10   ` Lachlan McIlroy
2008-12-09  9:22     ` Christoph Hellwig
2008-12-22  8:53       ` Christoph Hellwig
2008-12-23  0:40         ` Lachlan McIlroy
2008-12-23  8:40           ` Christoph Hellwig
2008-12-24  1:10             ` Lachlan McIlroy
2008-12-24  2:10               ` Niv Sardi
2008-12-24  2:23                 ` Lachlan McIlroy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49519D18.3080307@sgi.com \
    --to=lachlan@sgi.com \
    --cc=hch@infradead.org \
    --cc=xaiki@cxhome.ath.cx \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.