All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC][PATCH] Code Clean-up (weak functions)
Date: Thu, 25 Dec 2008 01:55:05 +0900	[thread overview]
Message-ID: <49526969.5000402@ruby.dti.ne.jp> (raw)
In-Reply-To: <005501c965d1$a95ceee0$fc16cca0$@Tjernlund@transmode.se>

Joakim Tjernlund wrote:
>>> - There is no purely weak functions and therfore no longer code like:
>>>     if (do_something)
>>>       do_somthing();
>>>   All instances have been replaced by empty functions with an alias. e.g.
>>>      void __do_something (args) {}
>>>      do_something(args) __atttribute__((weak, alias("__do_something")));
> 
> Curious as to why you removed such code? Was it because it didn't work? If
> so I might have an answer for that. See my post:
> "Re: [U-Boot] [PATCH V4] cmd_bdinfo: move implementation to	arch	instead of common"
> 
>  Jocke

Good to know.  This doc also helps:

http://docs.sun.com/app/docs/doc/817-1984/chapter2-11?l=en&a=view

Then,
- we must try to not leave undefined weak symbols at all,
- or check the symbol before invocation for the safety in case of NULL
  dereference.

  reply	other threads:[~2008-12-24 16:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-13  5:26 [U-Boot] [RFC][PATCH] Code Clean-up (weak functions) Graeme Russ
2008-12-13 22:48 ` Remy Bohmer
2008-12-14  9:23   ` Graeme Russ
2008-12-22  9:05 ` Mike Frysinger
2008-12-22  9:16   ` Graeme Russ
2008-12-22 11:44     ` Mike Frysinger
2008-12-22 11:20       ` Graeme Russ
2008-12-23  4:18         ` Mike Frysinger
2008-12-24  1:14 ` Shinya Kuribayashi
2008-12-24 14:12   ` Joakim Tjernlund
2008-12-24 16:55     ` Shinya Kuribayashi [this message]
2008-12-24 19:41       ` Remy Bohmer
2008-12-25  0:56         ` Shinya Kuribayashi
2008-12-25 11:26           ` Graeme Russ
2008-12-25 14:00       ` Joakim Tjernlund
2008-12-25 14:39         ` Shinya Kuribayashi
2008-12-25 11:22   ` Graeme Russ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49526969.5000402@ruby.dti.ne.jp \
    --to=skuribay@ruby.dti.ne.jp \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.