All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Sam Ravnborg <sam@ravnborg.org>,
	David Howells <dhowells@redhat.com>,
	mingo@elte.hu
Cc: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	mel@csn.ul.ie
Subject: [PATCH] perf_counter: more barrier in blank weak function
Date: Fri, 26 Dec 2008 21:05:06 -0800	[thread overview]
Message-ID: <4955B782.3030407@kernel.org> (raw)
In-Reply-To: <20081226102716.GA31450@uranus.ravnborg.org>


Impact: fix panic possible panic etc

some compiler seems to inline the weak global function if no line in it

Signed-off-by: Yinghai Lu <yinghai@kernel.org>

diff --git a/kernel/perf_counter.c b/kernel/perf_counter.c
index d7a79f3..37f7716 100644
--- a/kernel/perf_counter.c
+++ b/kernel/perf_counter.c
@@ -45,8 +45,8 @@ hw_perf_counter_init(struct perf_counter *counter)
 }
 
 u64 __weak hw_perf_save_disable(void)		{ return 0; }
-void __weak hw_perf_restore(u64 ctrl)		{ }
-void __weak hw_perf_counter_setup(void)		{ }
+void __weak hw_perf_restore(u64 ctrl)		{ barrier(); }
+void __weak hw_perf_counter_setup(void)		{ barrier(); }
 
 static void
 list_add_counter(struct perf_counter *counter, struct perf_counter_context *ctx)

  parent reply	other threads:[~2008-12-27  5:06 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-16 11:37 linux-next: Tree for December 16 Stephen Rothwell
2008-12-16 23:26 ` Andrew Morton
2008-12-17  6:59   ` linux-next: mtd tree build failures (Was: Re: linux-next: Tree for December 16) Stephen Rothwell
2008-12-17  9:32     ` Artem Bityutskiy
2008-12-17  9:57       ` Stephen Rothwell
2008-12-17  7:07   ` linux-next: Tree for December 16 Artem Bityutskiy
2008-12-17  7:08 ` next-20081216 - powerpc link error 'dynreloc miscount' Kamalesh Babulal
2008-12-17  7:08   ` Kamalesh Babulal
2008-12-17  7:28   ` Sam Ravnborg
2008-12-17  7:28     ` Sam Ravnborg
2008-12-17  7:30   ` Stephen Rothwell
2008-12-19 10:54 ` [BUG] next-20081216 - WARNING: at kernel/smp.c:333 smp_call_function_mask Kamalesh Babulal
2008-12-19 11:51   ` Yinghai Lu
2008-12-19 13:46     ` Kamalesh Babulal
2008-12-19 21:02       ` Yinghai Lu
2008-12-23 13:21         ` Kamalesh Babulal
2008-12-23 21:09           ` Yinghai Lu
2008-12-24 16:34             ` Kamalesh Babulal
2008-12-24 20:34               ` Yinghai Lu
2008-12-26  9:12                 ` Kamalesh Babulal
2008-12-26 10:05                   ` Yinghai Lu
2008-12-26 10:27                     ` Sam Ravnborg
2008-12-26 13:33                       ` Ingo Molnar
2008-12-26 13:42                         ` [PATCH] kbuild, sparseirq: work around GCC bug with __weak aliases Ingo Molnar
2008-12-27  4:09                           ` Paul Mackerras
2008-12-27 10:59                             ` Ingo Molnar
2008-12-28 23:27                               ` Paul Mackerras
2008-12-26 15:28                       ` [BUG] next-20081216 - WARNING: at kernel/smp.c:333 smp_call_function_mask Kamalesh Babulal
2008-12-26 15:33                         ` Ingo Molnar
2008-12-26 17:04                           ` Kamalesh Babulal
2008-12-26 18:17                             ` Ingo Molnar
2008-12-27  7:11                               ` Kamalesh Babulal
2008-12-27  7:14                                 ` Yinghai Lu
2008-12-27  7:39                                 ` Yinghai Lu
2008-12-27  8:37                                   ` Ingo Molnar
2008-12-27  8:39                                     ` Ingo Molnar
2008-12-27 11:21                                       ` Kamalesh Babulal
2008-12-27 11:24                                         ` Ingo Molnar
2008-12-27 11:57                                           ` Kamalesh Babulal
2008-12-27 12:26                                             ` Ingo Molnar
2008-12-27 15:29                                               ` Kamalesh Babulal
2008-12-27 21:10                                                 ` Yinghai Lu
2008-12-27 21:10                                                   ` Yinghai Lu
2008-12-28 12:55                                                 ` Ingo Molnar
2008-12-28 16:11                                                   ` Kamalesh Babulal
2008-12-28 23:09                                                     ` Yinghai Lu
2008-12-27  5:05                       ` Yinghai Lu [this message]
2008-12-27  5:06                         ` [PATCH] kgdb: more barrier in blank weak function Yinghai Lu
2008-12-27  8:17                           ` Ingo Molnar
2008-12-27  8:34                             ` Andrew Morton
2008-12-27  6:07                         ` [PATCH] perf_counter: " KOSAKI Motohiro
2008-12-27  9:46                       ` [BUG] next-20081216 - WARNING: at kernel/smp.c:333 smp_call_function_mask David Howells
2008-12-27  9:50                         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4955B782.3030407@kernel.org \
    --to=yinghai@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mel@csn.ul.ie \
    --cc=mingo@elte.hu \
    --cc=sam@ravnborg.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.