From: John Daiker <daikerjohn@gmail.com>
To: David Brownell <david-b@pacbell.net>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Julia Lawall <julia@diku.dk>,
gregkh@suse.de, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 10/13] drivers/usb/gadget: use USB API functions rather
Date: Mon, 29 Dec 2008 20:49:07 +0000 [thread overview]
Message-ID: <495937C3.7090101@gmail.com> (raw)
In-Reply-To: <200812291222.48966.david-b@pacbell.net>
On 12/29/2008 12:22 PM, David Brownell wrote:
> On Monday 29 December 2008, Alan Stern wrote:
>
>> On Mon, 29 Dec 2008, David Brownell wrote:
>>
>>
>>> Those functions were supposed to go into<linux/usb/ch9.h>, as
>>> I recall, since they weren't specific to the host side stack.
>>>
>>> Having them added to the wrong file is surely part of why
>>> they've only been used by host side drivers. :)
>>>
>> Would you like to write a patch moving the functions to ch9.h? Or
>> would you like to ask Julia or me to do it?
>>
>
> Someone other than me. ;)
>
> Maybe someone on K-J will want to volunteer with a patch
> before either you or Julia...
>
> - Dave
>
So you're saying that these functions:
usb_endpoint_dir_in(epd)
usb_endpoint_dir_out(epd)
usb_endpoint_is_bulk_in(epd)
usb_endpoint_is_bulk_out(epd)
usb_endpoint_is_int_in(epd)
usb_endpoint_is_int_out(epd)
usb_endpoint_num(epd)
usb_endpoint_type(epd)
usb_endpoint_xfer_bulk(epd)
usb_endpoint_xfer_control(epd)
usb_endpoint_xfer_int(epd)
usb_endpoint_xfer_isoc(epd)
Should be defined in ch9.h instead of usb.h?
If that's the case, then I'll be glad to cook up a patch! :)
~John
WARNING: multiple messages have this Message-ID (diff)
From: John Daiker <daikerjohn@gmail.com>
To: David Brownell <david-b@pacbell.net>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Julia Lawall <julia@diku.dk>,
gregkh@suse.de, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 10/13] drivers/usb/gadget: use USB API functions rather than constants
Date: Mon, 29 Dec 2008 12:49:07 -0800 [thread overview]
Message-ID: <495937C3.7090101@gmail.com> (raw)
In-Reply-To: <200812291222.48966.david-b@pacbell.net>
On 12/29/2008 12:22 PM, David Brownell wrote:
> On Monday 29 December 2008, Alan Stern wrote:
>
>> On Mon, 29 Dec 2008, David Brownell wrote:
>>
>>
>>> Those functions were supposed to go into<linux/usb/ch9.h>, as
>>> I recall, since they weren't specific to the host side stack.
>>>
>>> Having them added to the wrong file is surely part of why
>>> they've only been used by host side drivers. :)
>>>
>> Would you like to write a patch moving the functions to ch9.h? Or
>> would you like to ask Julia or me to do it?
>>
>
> Someone other than me. ;)
>
> Maybe someone on K-J will want to volunteer with a patch
> before either you or Julia...
>
> - Dave
>
So you're saying that these functions:
usb_endpoint_dir_in(epd)
usb_endpoint_dir_out(epd)
usb_endpoint_is_bulk_in(epd)
usb_endpoint_is_bulk_out(epd)
usb_endpoint_is_int_in(epd)
usb_endpoint_is_int_out(epd)
usb_endpoint_num(epd)
usb_endpoint_type(epd)
usb_endpoint_xfer_bulk(epd)
usb_endpoint_xfer_control(epd)
usb_endpoint_xfer_int(epd)
usb_endpoint_xfer_isoc(epd)
Should be defined in ch9.h instead of usb.h?
If that's the case, then I'll be glad to cook up a patch! :)
~John
next prev parent reply other threads:[~2008-12-29 20:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 10:22 [PATCH 10/13] drivers/usb/gadget: use USB API functions rather than Julia Lawall
2008-12-29 10:22 ` [PATCH 10/13] drivers/usb/gadget: use USB API functions rather than constants Julia Lawall
2008-12-29 15:27 ` [PATCH 10/13] drivers/usb/gadget: use USB API functions rather Alan Stern
2008-12-29 15:27 ` [PATCH 10/13] drivers/usb/gadget: use USB API functions rather than constants Alan Stern
2008-12-29 15:35 ` [PATCH 10/13] drivers/usb/gadget: use USB API functions rather Julia Lawall
2008-12-29 15:35 ` [PATCH 10/13] drivers/usb/gadget: use USB API functions rather than constants Julia Lawall
2008-12-29 18:14 ` David Brownell
2008-12-29 18:14 ` David Brownell
2008-12-29 16:13 ` [PATCH 10/13] drivers/usb/gadget: use USB API functions rather Alan Stern
2008-12-29 16:13 ` [PATCH 10/13] drivers/usb/gadget: use USB API functions rather than constants Alan Stern
2008-12-29 16:18 ` [PATCH 10/13] drivers/usb/gadget: use USB API functions rather Julia Lawall
2008-12-29 16:18 ` [PATCH 10/13] drivers/usb/gadget: use USB API functions rather than constants Julia Lawall
2008-12-29 19:54 ` [PATCH 10/13] drivers/usb/gadget: use USB API functions rather Alan Stern
2008-12-29 19:54 ` [PATCH 10/13] drivers/usb/gadget: use USB API functions rather than constants Alan Stern
2008-12-29 20:22 ` David Brownell
2008-12-29 20:22 ` David Brownell
2008-12-29 20:37 ` [PATCH 10/13] drivers/usb/gadget: use USB API functions rather Julia Lawall
2008-12-29 20:37 ` [PATCH 10/13] drivers/usb/gadget: use USB API functions rather than constants Julia Lawall
2008-12-29 20:49 ` John Daiker [this message]
2008-12-29 20:49 ` John Daiker
2008-12-29 21:01 ` David Brownell
2008-12-29 21:01 ` David Brownell
2008-12-29 21:01 ` [PATCH 10/13] drivers/usb/gadget: use USB API functions rather Alan Stern
2008-12-29 21:01 ` [PATCH 10/13] drivers/usb/gadget: use USB API functions rather than constants Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=495937C3.7090101@gmail.com \
--to=daikerjohn@gmail.com \
--cc=david-b@pacbell.net \
--cc=gregkh@suse.de \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.