All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: "Lubomír Bulej" <lubomir.bulej@dsrg.mff.cuni.cz>,
	jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: blacklist NCQ on OCZ CORE 2 SSD (resend)
Date: Tue, 30 Dec 2008 09:35:06 +0900	[thread overview]
Message-ID: <49596CBA.8090903@kernel.org> (raw)
In-Reply-To: <495899A9.8030507@ru.mvista.com>

Sergei Shtylyov wrote:
> Hello.
> 
> Tejun Heo wrote:
> 
>>> The patchlet below blacklists NCQ on OCZ CORE v2 SSD drive(s). Even
>>> though the drive advertises NCQ support with queue depth 1, it responds
>>> with all-zeroes FIS to NCQ commands which triggers ata error handling
>>> several times before the kernel decides to disable NCQ on the drive.
>>>
>>> signed-off-by: Lubomir Bulej <lubomir.bulej@dsrg.mff.cuni.cz>
>>>     
>>
>> Please capitalize the leading s and add --- separator between
>> description and the patch body.
> 
>   Why Lubomir needs to add --- if there's no diffstat or comments? :-

Hmm... now come to think of it, you're right.  I guess I'm now just
too accustomed to seeing it.

Thanks.

-- 
tejun

  reply	other threads:[~2008-12-30  0:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-22 10:35 [PATCH] libata: blacklist NCQ on OCZ CORE 2 SSD (resend) Lubomír Bulej
2008-12-29  8:39 ` Tejun Heo
2008-12-29  9:34   ` Sergei Shtylyov
2008-12-30  0:35     ` Tejun Heo [this message]
2008-12-29 12:41 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49596CBA.8090903@kernel.org \
    --to=tj@kernel.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=lubomir.bulej@dsrg.mff.cuni.cz \
    --cc=sshtylyov@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.