All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Leblond <eric@inl.fr>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnetfilter_log 2/3] Set nflog_errno as needed.
Date: Tue, 30 Dec 2008 12:19:25 +0100	[thread overview]
Message-ID: <495A03BD.4010805@netfilter.org> (raw)
In-Reply-To: <1230586404-24639-3-git-send-email-eric@inl.fr>

Eric Leblond wrote:
> Some FIXME were put to fix some issues related to nflog_errno not being set. In both case, this was
> related to error treatment of libnfnetlink function. As these functions are setting errno to the
> correct value, this patch simply copy errno to nflog_errno in libnetfilter_log.

I doubt that anyone if using nf*_errno at this moment since t is not of
any help. We have no internal errno values different than those defined
in errno.h. I think it's better to use errno instead, at least for this
version of the API. See libnetfilter_conntrack.

For the upcoming version, we can introduce the nf*_errno again and
define internal errors. Same applies for libnetfilter_queue.

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers

  reply	other threads:[~2008-12-30 12:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-29 21:33 [libnetfilter_log 0/3] Misc code cleaning Eric Leblond
2008-12-29 21:33 ` [libnetfilter_log 1/3] Suppress reference to libnetfilter_queue which is the model of libnetfilter_log Eric Leblond
2008-12-30 11:19   ` Pablo Neira Ayuso
2008-12-29 21:33 ` [libnetfilter_log 2/3] Set nflog_errno as needed Eric Leblond
2008-12-30 11:19   ` Pablo Neira Ayuso [this message]
2008-12-29 21:33 ` [libnetfilter_log 3/3] Suppress NFULNL_MSG_CONFIG callback registration Eric Leblond
2008-12-30 11:20   ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=495A03BD.4010805@netfilter.org \
    --to=pablo@netfilter.org \
    --cc=eric@inl.fr \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.