From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 2/3] Don't return to guest after CPU issued S3 command.
Date: Tue, 30 Dec 2008 15:25:29 +0200 [thread overview]
Message-ID: <495A2149.5000106@redhat.com> (raw)
In-Reply-To: <20081230123256.GB3326@redhat.com>
Gleb Natapov wrote:
> On Tue, Dec 30, 2008 at 01:19:22PM +0200, Avi Kivity wrote:
>
>>> +int kvm_shutdown(void *opaque, void *data);
>>>
>> That's a bad API. What's the opaque? what's the data?
>>
>>
> How about this one:
>
> Don't return to guest CPU after qemu_system_reset_request().
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-12-30 13:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-30 10:37 [PATCH 0/3] Remaining S3 bits Gleb Natapov
2008-12-30 10:37 ` [PATCH 1/3] Reset stack pointer to zero on S3 resume Gleb Natapov
2008-12-30 10:37 ` [PATCH 2/3] Don't return to guest after CPU issued S3 command Gleb Natapov
2008-12-30 11:19 ` Avi Kivity
2008-12-30 12:32 ` Gleb Natapov
2008-12-30 13:25 ` Avi Kivity [this message]
2008-12-30 10:37 ` [PATCH 3/3] KVM does not support SMM. Disable it Gleb Natapov
2008-12-30 11:25 ` [PATCH 0/3] Remaining S3 bits Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=495A2149.5000106@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.